Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center FAQ header and allow multiple accordion items to expand #2697

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

use-tusk[bot]
Copy link
Contributor

@use-tusk use-tusk bot commented Sep 27, 2024

Centered the "Frequently Asked Questions" header on one line and removed the line break for better UI presentation. Modified the accordion functionality to allow multiple items to be expanded simultaneously, enriching the user experience. The changes were made in the bifrost/components/templates/landing/faqs.tsx file, adjusting the header styling and updating state management logic.


Browser testing result ✅

Success images

Step: [Verify] The 'Frequently Asked Questions' header is centered on one line.

The 'Frequently Asked Questions' header is centered on one line. This is confirmed by the screenshot, where the header is clearly visible in the center of the page and spans only one line.

Success Image 0-0
Step: [Verify] Both FAQ answers remain expanded after clicking the second question.

The assertion is that both FAQ answers remain expanded after clicking the second question. The screenshot shows that the answers to both questions are visible, indicating that they are expanded. Therefore, the assertion is true.

Success Image 1-0


Tips:

  • Make sure to test changes before merging.
  • Submit a "Request Changes" review and I'll address it.
  • Close this PR with a comment if it's obviously incorrect. This will improve my future PRs.
  • Go to the Tusk activity logs to see more details.

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helicone ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:41am
helicone-bifrost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:41am
helicone-eu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:41am

@use-tusk use-tusk bot changed the title Tusk WIP - Marketing website FAQ section UI tweaks Center FAQ header and allow multiple accordion items to expand Sep 27, 2024
@use-tusk use-tusk bot marked this pull request as ready for review September 27, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants