Add scores on request page #1957
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| /> | ||
| </div> | ||
| </div> | ||
| <button |
There was a problem hiding this comment.
nit: Use HcButton component
| Key | ||
| </label> | ||
| <div className=""> | ||
| <input |
| Value | ||
| </label> | ||
| <div className=""> | ||
| <input |
| <div className="font-semibold text-gray-900 dark:text-gray-100 text-sm items-center flex"> | ||
| Scores{" "} | ||
| <Tooltip title="Add a new score" placement="top"> | ||
| <button |
| return; | ||
| } | ||
| try { | ||
| const res = await addRequestScore( |
There was a problem hiding this comment.
Q: Can a request have more than 1 score? If im understanding right, the addRequestScore function adds a score to an array of scores?
There was a problem hiding this comment.
@ScottMktn Yes, request can have multiple scores but user can add scores 1 by 1 like custom properties
|
|
||
| if (currentScores && currentScores[key]) { | ||
| setNotification("Score already exists", "error"); | ||
| setIsScoresAdding(false); |
There was a problem hiding this comment.
nit: in the future, to avoid having to set states everything for loading, use useMutation
https://tanstack.com/query/v4/docs/framework/react/reference/useMutation
|
For next time, for frontend stuff, please post a screenshot so that it's slightly easier to test. But otherwise, code looks good! |
|
It's gonna look like this |
Add scores on request page