Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead image reference to "Fork me on GitHub" #154

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

metalefty
Copy link
Contributor

Switched to CSS implementation hosted on cdsjs.com. It should be more permanent than githubusercontent.com.

Resolves: #153


image

@geek-at
Copy link
Member

geek-at commented Apr 15, 2024

Nice thank you! But I think you missed the actual css class of github-fork-ribbon

@metalefty
Copy link
Contributor Author

Thanks, let me chck.

@metalefty
Copy link
Contributor Author

github-fork-ribbon is at line 43. This PR looks good to me.

@geek-at
Copy link
Member

geek-at commented Apr 20, 2024

Oh I see you included the css from a CDN. Can you please include it locally just to be more GDPR compliant 😁

@metalefty
Copy link
Contributor Author

Understood, will do.

Switched to CSS implementation hosted on cdsjs.com. It should be
more permanent than githubusercontent.com.

Resolves: HaschekSolutions#153
@metalefty
Copy link
Contributor Author

Moved CSS to local.

@geek-at geek-at merged commit f62b30d into HaschekSolutions:master Apr 21, 2024
1 check passed
@geek-at
Copy link
Member

geek-at commented Apr 21, 2024

thank you 😁

@metalefty metalefty deleted the fork-me branch April 21, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fork me on GitHub img reference is dead
2 participants