Chore: Adhere To Awesome Go Guidelines #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irements from awesome-go; prepare badges expected by awesome-go in README.md;
…after test result is out;
…; revert back coverage badge changes on README.md;
… base branch to github.ref;
…o .output; update .gitignore inside .output to keep include cov-report dir;
…e, this is so people could be more comfortable when commiting to the PR;
riandyrn
requested review from
knightazura,
harunalfat,
isdzulqor and
ilhamsyahids
harunalfat
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this guideline, in order for our project to be eligible for review we need to have following elements:
pkg.go.devThe biggest challenge is actually no. 3, this is because up until now we still don't get approval to install ready to use code coverage service such as
CodecovinHaraj-backendorganization.But luckily the
Awesome Goteam also allowed for us to create the code coverage service on our own (see here). So yeah, in this PR basically I'm creating this service (see here for details).Close #43.