-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Refine README.md #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o want to know how to write production-grade code for Haraj projects;
This reverts commit 39e99f6.
…irements from awesome-go; prepare badges expected by awesome-go in README.md;
…after test result is out;
harunalfat
reviewed
Jul 16, 2023
…; revert back coverage badge changes on README.md;
… base branch to github.ref;
…o .output; update .gitignore inside .output to keep include cov-report dir;
…e, this is so people could be more comfortable when commiting to the PR;
…guideline Chore: Adhere To Awesome Go Guidelines
riandyrn
requested review from
knightazura,
harunalfat,
isdzulqor and
ilhamsyahids
July 17, 2023 05:39
harunalfat
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isdzulqor
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Awesome 🎉
knightazura
reviewed
Jul 17, 2023
… if failed when determine changes since it is not necessary;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think not everyone can easily realized the benefit of writing maintainable code.
So in this PR I attempt to position this repo as getting started guidelines to write production-grade code for Haraj projects.
Let me your opinion about this, @harunalfat.