Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for browser color preferences #1232

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

ggvbo
Copy link
Contributor

@ggvbo ggvbo commented May 8, 2023

Sets the default value for Dark Mode depending on the browser's prefers-color-scheme media query, also listening to changes in the browser's media query.

@MiniDigger
Copy link
Member

MiniDigger commented Jul 31, 2023

mmmh, I dont like this solution, we already have code for this in useSettingsHelper, but somehow that doesn't work as expected
edit: I think the db has a default value, thats why the thing doesnt work.
maybe we should only save to db if the user actually uses the button? else just rely on the media query?
but that would mean the server would serve stuff in the wrong color, which is meh too....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants