Dropship Move Sound Effects & Swamp Tree Icon Fix #3531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
X0-11
requested changes
Feb 3, 2024
| @@ -99,6 +99,8 @@ | |||
|
|
|||
| overmap_range = 10 | |||
|
|
|||
| move_sound = 'code/modules/halo/sounds/vehicle_sfx/pelican_move.ogg' | |||
There was a problem hiding this comment.
You can just put these sfx links in the baseline define for the vehicle so it's passed down to subtypes, rather than putting one in each subtype
BDpuffy420
approved these changes
Feb 4, 2024
hs-cicero
added a commit
that referenced
this pull request
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑 YourPalHolidays
rscadd: Adds move sound effects for both the Pelican and Phantom Dropship. The sound effects may be a bit quiet for some people, but that is intentional as the sound effect overlaps and would eventually get too loud.
bugfix: Fixes the glowing swamp trees icon path, as it was deleted.
/:cl: YourPalHolidays