Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KS7 Marshal Overhaul Update #3426

Closed
wants to merge 13 commits into from
Closed

KS7 Marshal Overhaul Update #3426

wants to merge 13 commits into from

Conversation

YourPalHolidays
Copy link
Collaborator

🆑 YourPalHolidays(Tsar)
rscadd: Added new Marshal gear and custom sprites. (Original credit goes to Eluxor)
rscadd: Overhauls KS7's police department.
tweak: Fixes the GCPD slowdown gear bug.
/:cl:

@YourPalHolidays YourPalHolidays requested review from a team as code owners July 31, 2023 21:43
Copy link
Member

@Aroliacue Aroliacue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this. Sprites look smooth!

Copy link
Collaborator

@X0-11 X0-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please also put some description of the changes to the PD

@@ -30,3 +30,5 @@ __pycache__
code/modules/halo/flood/types/flood_shield.dm
code/modules/halo/flood/types/sangheili.dm
code/modules/halo/vehicles/types/phantom_dropship.dm
baystation12.dme
baystation12.dme
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why has this been changed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kerfuffle with inclusion and a ignore githhub that I must have did wrong, there should be no changes to the indicated files, if there is then something is wrong on my end.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are changes, that's what github tracks

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that is the case then I will cancel this merge request, I have not knowingly modified those files in any way and look into my own fork to see why those files have been changed.

#include "maps\geminus_city\geminus_city.dm"
#include "maps\ks7_elmsville\includes.dm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not have been PR'd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitignore moment 2.0.

@@ -3350,7 +3351,9 @@
#include "maps\_gamemodes\_popbalance.dm"
#include "maps\_gamemodes\gamemode_overrides.dm"
#include "maps\_gamemodes\randantag\randantag.dm"
#include "maps\faction_bases\civ_shuttle.dm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nor should have this been PR'd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitignore moment.

Copy link
Collaborator Author

@YourPalHolidays YourPalHolidays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update overhauls the KS7 Marshals with new equipment, gear and apparel, as well as changes to their PD including a left that leads to a underground garage, several QoL rooms, a mayors office on the second floor along with a expanded armory and other various facilities to promote a more enjoyable experience for KS7 Colonial Marshal players.

@@ -30,3 +30,5 @@ __pycache__
code/modules/halo/flood/types/flood_shield.dm
code/modules/halo/flood/types/sangheili.dm
code/modules/halo/vehicles/types/phantom_dropship.dm
baystation12.dme
baystation12.dme
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kerfuffle with inclusion and a ignore githhub that I must have did wrong, there should be no changes to the indicated files, if there is then something is wrong on my end.

@@ -3350,7 +3351,9 @@
#include "maps\_gamemodes\_popbalance.dm"
#include "maps\_gamemodes\gamemode_overrides.dm"
#include "maps\_gamemodes\randantag\randantag.dm"
#include "maps\faction_bases\civ_shuttle.dm"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitignore moment.

#include "maps\geminus_city\geminus_city.dm"
#include "maps\ks7_elmsville\includes.dm"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitignore moment 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants