Improve logging for debugging startup issues #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniversalSuperBox
requested changes
Mar 24, 2021
|
|
||
| if [ "$ANDROID_IMAGE_MODE" = "unknown" ]; then | ||
| halium_panic "Could not identify Android system image!" | ||
| fi |
There was a problem hiding this comment.
While you wouldn't guess it from the name, initramfs-tools-halium may be used in cases where no Android image is present. It's not appropriate to panic in these cases.
I think there is a warning for the Android image not being found, though?
There was a problem hiding this comment.
Ok I´ll remove it. The problem remains, why continue trying to boot if something essential is missing? If the system.img is missing then a bunch of errors is written out, and still the thing tries to start LXC it seems. I wanted to have a clear stop condition somewhere so that people can see, okay at the very end of the log: This is the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging the boot mode and file layout. During my porting I found it always hard to spot reasons for stuck boot in dmesg. Also, adding a condition to the file layout detection to require both system.img and rootfs.img to be present for Halium layout type.