Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_engine: add back missing header file #11

Open
wants to merge 1 commit into
base: halium-9.0
Choose a base branch
from

Conversation

calebccff
Copy link

update_engine had a header file removed that for some reason can't be found on hybris based builds on the OnePlus 6 at least, add back the header to make it happy.

Change-Id: Ic47f6bd7a34ca5f2750727e2ac7ec99c2aa38bbd
@calebccff
Copy link
Author

This is also needed for the Pixel 2 XL. Can we get it merged? :D

@NotKit
Copy link
Collaborator

NotKit commented Jan 12, 2021

Which repo is it supposed to come from originally?

@calebccff
Copy link
Author

@NotKit It's from https://github.com/LineageOS/android_system_update_engine, it got removed (and I think moved to a different repo that isn't included in halium 9 builds).

@NotKit
Copy link
Collaborator

NotKit commented Jan 12, 2021

@calebccff do you know which repo it got moved to? If possible, I'd prefer to get that repo back to minimize amount of changes we add on top. On the other hand, update_engine itself does not make sense in Halium builds and can be safely removed from device trees.

@calebccff
Copy link
Author

@calebccff do you know which repo it got moved to? If possible, I'd prefer to get that repo back to minimize amount of changes we add on top. On the other hand, update_engine itself does not make sense in Halium builds and can be safely removed from device trees.

I don't know where it went... Removing update_engine does seem like a more sensible solution. @NotKit

@calebccff
Copy link
Author

I had a look at removing update_engine but it doesn't seem massively feasible, then again I'm not particularly comfortable working with Android build files. Unless there's a good reason not to it's probably easiest to keep this patch.

@Herrie82
Copy link

I thought we normally remove update engine from builds? It's not something we should need anyway?

@Thaodan
Copy link

Thaodan commented Jun 11, 2022

Update engine can be disabled I think. We disable update_verifier for hybris already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants