-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
created functions to create/edit/delete questions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MD/swaliga-foundation into update-form-and-db
Recent updates:
|
Update:
|
nkanchinadam
approved these changes
Apr 8, 2024
@@ -0,0 +1,22 @@ | |||
import {forms } from '../../../lib/googleAuthorization'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put this file in /src/lib/forms, shouldn't be an API endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created functions for creating, editing, and deleting questions using batchUpdate and passing through the proper requestBody into the function.
handler: An attempt to connect the client and the server side for using the create, edit, and delete functions. This part was a bit iffy for me because I'm still trying to get familiar with this concept.
None of the create/edit functions do any type checking. Not sure if this is needed due to the wide range of question types, option types, etc. Therefore, these functions were created with the assumption that when used, the question to add or the edited version of the question will be in the proper format and have the required fields.
Create/edit functions use createItem and updateItem respectively, and the question fields are set with the passed-in questions. These union fields will be sent as their corresponding Request types in batchUpdate.
The delete function should do as expected--it should refer to the passed-in index of the question that needs to be deleted via union field of deleteItem and sent as a DeleteItemRequest in batchUpdate.
Finally, each function should update the corresponding form document in firebase with the modified data.
See the documentation in the code for more.