shortened import statements, used id for creating response, and modif…

…ied error messages
Hack4Impact-UMD · Apr 10, 2024 · 65a8537 · 65a8537
1 parent 030f25a
commit 65a8537
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/app/api/responses/[responseId]/route.tsx b/src/app/api/responses/[responseId]/route.tsx
@@ -1,6 +1,6 @@
 import { NextRequest, NextResponse } from 'next/server';
-import { getResponseByID } from '../../../../lib/firebase/database/response';
-import { Response } from '../../../../types/survey-types';
+import { getResponseByID } from '@/lib/firebase/database/response';
+import { Response } from '@/types/survey-types';
 
 export async function GET(req: NextRequest, { params }: { params: { responseId: string } }) {
   const { responseId } = params; 

diff --git a/src/app/api/responses/route.tsx b/src/app/api/responses/route.tsx
@@ -1,16 +1,16 @@
 // pages/route.tsx
 
 import { NextRequest, NextResponse } from 'next/server';
-import { getAllResponses, createResponse } from '../../../lib/firebase/database/response';
-import { Response } from '../../../types/survey-types';
+import { getAllResponses, createResponse } from '@/lib/firebase/database/response';
+import { Response } from '@/types/survey-types';
 
 export async function GET(req: NextRequest) {
   try {
     const allResponses = await getAllResponses();
     return NextResponse.json(allResponses, { status: 200 });
   } catch (error) {
     console.error('Error getting responses:', error);
-    return NextResponse.json({ message: 'Internal Server Error' }, { status: 500 });
+    return NextResponse.json({ error: 'Internal Server Error' }, { status: 500 });
   }
 }
 
@@ -21,6 +21,6 @@ export async function POST(req: NextRequest) {
     return NextResponse.json({ message: 'Response created successfully' }, { status: 201 });
   } catch (error) {
     console.error('Error creating response:', error);
-    return NextResponse.json({ message: 'Internal Server Error' }, { status: 500 });
+    return NextResponse.json({ error: 'Internal Server Error' }, { status: 500 });
   }
 }
diff --git a/src/lib/firebase/database/response.ts b/src/lib/firebase/database/response.ts
@@ -1,6 +1,6 @@
 import { db } from "../firebaseConfig";
-import { collection, getDocs, addDoc, getDoc, doc } from 'firebase/firestore';
-import { Response } from '../../../types/survey-types';
+import { collection, getDocs, getDoc, doc, setDoc } from 'firebase/firestore';
+import { Response } from '@/types/survey-types';
 
 // GET all responses
 export async function getAllResponses() {
@@ -13,16 +13,16 @@ export async function getAllResponses() {
     return allResponses;
   } catch (error) {
     console.error('Error getting responses:', error);
-    throw new Error('Internal Server Error');
+    throw new Error('unable to get responses');
   }
 }
 
 export async function createResponse(newResponse: Response) {
   try {
-    await addDoc(collection(db, 'responses'), newResponse);
+    await setDoc(doc(db, 'responses', newResponse.responseId), newResponse);
   } catch (error) {
     console.error('Error creating response:', error);
-    throw new Error('Internal Server Error');
+    throw new Error('unable to create response');
   }
 }
 export async function getResponseByID(responseId: string): Promise<Response | null> {
@@ -35,6 +35,6 @@ export async function getResponseByID(responseId: string): Promise<Response | nu
       }
     } catch (error) {
       console.error('Error getting response by ID:', error);
-      throw new Error('Internal Server Error');
+      throw new Error('unable to get response by id');
     }
 }