Merge pull request #677 from HO-CTO/feature/sw-adjust-sli-protect-fro…

…m-division-by-0 fix: Generate correct value for SLI even if there are no metrics available (div/0)
HO-CTO · Oct 4, 2024 · c188ed8 · c188ed8
2 parents 585094e + 08036c8
commit c188ed8
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/...es/availability-gauge-using-1-failure-metric-for-num-and-1-total-metric-for-dem.libsonnet b/...es/availability-gauge-using-1-failure-metric-for-num-and-1-total-metric-for-dem.libsonnet
@@ -30,9 +30,11 @@ local createSliValueRule(sliSpec, sliMetadata, config) =
       expr: |||
         sum without (%(selectorLabels)s) (label_replace(label_replace(
           (
-            sum by(%(selectorLabels)s) (avg_over_time(%(failureMetric)s{%(selectors)s}[%(evalInterval)s])>=0)
-            /
-            sum by(%(selectorLabels)s) (avg_over_time(%(totalMetric)s{%(selectors)s}[%(evalInterval)s])>=0)
+            (
+              sum by(%(selectorLabels)s) (avg_over_time(%(failureMetric)s{%(selectors)s}[%(evalInterval)s])>=0)
+              /
+              sum by(%(selectorLabels)s) (avg_over_time(%(totalMetric)s{%(selectors)s}[%(evalInterval)s])>=0)
+            ) > 0 or on() vector(0)
           ),
         "sli_environment", "$1", "%(environmentSelectorLabel)s", "(.*)"), "sli_product", "$1", "%(productSelectorLabel)s", "(.*)"))
       ||| % {
@@ -94,9 +96,11 @@ local createGraphPanel(sliSpec) =
   ).addTarget(
     prometheus.target(
       |||
+        (
         sum(avg_over_time(%(failureMetric)s{%(selectors)s}[%(evalInterval)s]) >=0 or vector(0))
         /
         sum(avg_over_time(%(totalMetric)s{%(selectors)s}[%(evalInterval)s]) >=0 or vector(0))
+        ) > 0 or on() vector(0)
       ||| % {
         failureMetric: targetMetrics.failure,
         totalMetric: targetMetrics.total,