Adding possibility to estimate material budget not only in eta, but a… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso in cos(theta) and theta, and also make 2D plots of eta/theta/cosTheta vs. phi
|
Hi @armin-ilg the crash in stable stack is expected. @BrieucF I would merge this or you have some comments? |
…eck for valid m_angleDef input
…n_2D_genericAngle to ensure backwards compatibility, add comment about this in MaterialScan.h
|
LGTM, thanks Armin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lso in cos(theta) and theta, and also make 2D plots of eta/theta/cosTheta vs. phi
This can be used in the same way as before, with the material_scan.py+material_plots.py / material_scan_2D.py+material_plots_2D.py that I'm also soon pushing to k4geo (see MR).