Replacing legacy Podio service with the frame Podio service #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fail of stable stack tests expected. |
|
Hi Juraj, have you checked that the output is still the same when calling the cellID encoding? |
|
The frame related changes to k4RecCalorimeter are already merged. The test |
|
Can you profit from this to also replace the calls to FCCDataSvc in k4RecCalorimeter job options: https://github.com/search?q=repo%3AHEP-FCC%2Fk4RecCalorimeter%20FCCDataSvc&type=code ? |
|
Changed all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing all instances of Podio legacy data service with the new one supporting podio frame.