Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REQUIRED in find_package #40

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add REQUIRED in find_package #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
687dcea
Add REQUIRED in find_package
jmcarcell Oct 28, 2024
2dbfe10
Add more REQUIRED
jmcarcell Oct 28, 2024
882d943
Fix warning
jmcarcell Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ endif()

#- Dependencies ------------------------------------------------
find_package(ROOT COMPONENTS RIO Tree)
find_package(Gaudi)
find_package(k4FWCore)
find_package(EDM4HEP)
find_package(Gaudi REQUIRED)
find_package(k4FWCore REQUIRED)
find_package(EDM4HEP REQUIRED)

# use FindHEPPDT from Gaudi (used when finding heppdt later)
set(CMAKE_MODULE_PATH ${Gaudi_LIBRARY_DIR}/cmake/Gaudi/modules ${CMAKE_MODULE_PATH})
Expand Down
6 changes: 3 additions & 3 deletions k4Gen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
# Package: k4Gen
################################################################################

find_package(HepMC3)
find_package(HepMC3 REQUIRED)
find_package(Pythia8 COMPONENTS pythia8 pythia8tohepmc)
find_package(HepPDT)
find_package(EvtGen)
find_package(HepPDT REQUIRED)
find_package(EvtGen REQUIRED)

file(GLOB k4gen_plugin_sources src/components/*.cpp)
gaudi_add_module(k4Gen
Expand Down
2 changes: 1 addition & 1 deletion k4Gen/src/components/GenEventFilter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class GenEventFilter : public Gaudi::Algorithm {
"particles", Gaudi::DataHandle::Reader, this};
/// Writes out filter statistics.
MetaDataHandle<std::vector<int>> m_evtFilterStats{
edm4hep::EventFilterStats, Gaudi::DataHandle::Writer};
edm4hep::labels::EventFilterStats, Gaudi::DataHandle::Writer};

/// Rule to filter the events with.
Gaudi::Property<std::string> m_filterRuleStr{
Expand Down
Loading