Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HDF5_ENABLE_Z_LIB_SUPPORT to HDF5_ENABLE_ZLIB_SUPPORT #5074

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

byrnHDF
Copy link
Contributor

@byrnHDF byrnHDF commented Nov 5, 2024

No description provided.

@byrnHDF byrnHDF added Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 2. Medium ⏹ It would be nice to have this in the next release Component - Build CMake, Autotools Type - Improvement Improvements that don't add a new feature or functionality Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Component - Misc Anything else (CODEOWNERS, etc.) labels Nov 5, 2024
@byrnHDF byrnHDF self-assigned this Nov 5, 2024
@jhendersonHDF
Copy link
Collaborator

As a bikeshed argument, this makes more sense to me as Z_LIB since it's the 'z' library (libz.so, for example). I think the main argument though is that this will probably cause some headache downstream somewhere for no real good reason.

@brtnfld
Copy link
Contributor

brtnfld commented Nov 5, 2024

I think it is more in line with FindZLIB for cmake, which always references it as zlib with no underscore.

@byrnHDF
Copy link
Contributor Author

byrnHDF commented Nov 5, 2024

As a bikeshed argument, this makes more sense to me as Z_LIB since it's the 'z' library (libz.so, for example). I think the main argument though is that this will probably cause some headache downstream somewhere for no real good reason.

Yes, it is a good argument, except everyone seems to refer to it as the zlib library. This would be the best time to make the change.

@lrknox lrknox merged commit d09ea66 into HDFGroup:develop Nov 5, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Merge - Develop Only This cannot be merged to previous versions of HDF5 (file format or breaking API changes) Priority - 2. Medium ⏹ It would be nice to have this in the next release Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants