Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H5VLstart_lib_state and H5VLfinish_lib_state have been renamed #5069

Closed
wants to merge 82 commits into from
Closed
Show file tree
Hide file tree
Changes from 67 commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
27d52ae
corrected Fortran docs for hyperslab selection
brtnfld Oct 16, 2024
eeaf603
Fix h5py GitHub Action (#4962)
hyoklee Oct 17, 2024
8572d10
Do not package debug builds (#4963)
byrnHDF Oct 17, 2024
ff6cead
Updated hyperslab documentation (#4965)
brtnfld Oct 17, 2024
a23f20b
Fix linker flag in pkg-config file for system zlib (#4957)
cho-m Oct 17, 2024
b1576ab
Incorporate remaining parts of the filters.html file (#4966)
byrnHDF Oct 18, 2024
c821b49
Remove TRUE and FALSE from H5private.h (#4969)
derobins Oct 18, 2024
cdd91b9
Moved timer functionality to (new) H5timer.h (#4970)
derobins Oct 18, 2024
995819f
The h5(p)*c parser retains escaped whitespace character (#4967)
brtnfld Oct 18, 2024
59f553a
Move warning suppression macros to H5warnings.h (#4972)
derobins Oct 18, 2024
a8b93dc
Switch HDoff_t from __int64 to int64_t on Windows (#4973)
derobins Oct 18, 2024
4f5a203
Remove FALSE from some API tests (#4977)
jhendersonHDF Oct 18, 2024
83427ca
Set the C standard to 11 (#4975)
derobins Oct 18, 2024
6dafdc2
Remove the high-level GIF tools (#4976)
derobins Oct 18, 2024
048387c
Renamed COPYING to LICENSE (#4978)
derobins Oct 19, 2024
43215e6
Always check for __attribute__() in CMake (#4980)
derobins Oct 20, 2024
3f2d5b1
Remove some Solaris Studio work-arounds (#4979)
derobins Oct 20, 2024
ae46e48
Check in generated files in src (#4981)
derobins Oct 20, 2024
3578d40
Move h5_test_init() calls after MPI_Init (#4988)
jhendersonHDF Oct 21, 2024
415a77e
Remove bin/cmakehdf5
derobins Oct 22, 2024
fb6114f
Replace COPYING with LICENSE in workflows (#4989)
byrnHDF Oct 22, 2024
250b058
Prefix remaining CMake options except for CMake BUILD* variables (#4990)
byrnHDF Oct 22, 2024
630bb61
Add remaining CMake workflow versions of autotools workflows (#4998)
byrnHDF Oct 23, 2024
5fec29f
Disable Julia CI (#4999)
derobins Oct 23, 2024
a20f1b9
Remove another couple of H5E_clear_stack calls (#4968)
qkoziol Oct 23, 2024
13af19e
Add support for native zlib-ng in the library and compression referen…
byrnHDF Oct 23, 2024
e75ab74
Patch Julia CI (#5001)
derobins Oct 24, 2024
f1a1a56
Updated zlib and libaec compression versions (#4953)
byrnHDF Oct 24, 2024
7693ed4
Add szip documentation to dataset section of user guide (#4997)
byrnHDF Oct 24, 2024
f923242
Refactor H5FD and package initialization (#4934)
qkoziol Oct 24, 2024
46745b9
Refactor allocation of API context (#4942)
qkoziol Oct 24, 2024
4cb318e
Update the README (#5003)
derobins Oct 24, 2024
e70cf87
Certain versions of VS produce rounding errors in tfloatsattr (#5000)
byrnHDF Oct 24, 2024
746e788
Update README.md
derobins Oct 24, 2024
08f3fd0
Switch default for HDF5_GENERATE_HEADERS (CMake) to OFF. (#5005)
lrknox Oct 25, 2024
23fad2b
Split out compiler flags into specific compiler files (#4974)
byrnHDF Oct 25, 2024
873f13b
Get the Autotools version number from H5public.h (#5009)
derobins Oct 25, 2024
80797eb
Fix h5py CI failure (#5007)
hyoklee Oct 25, 2024
024576a
Move cygwin workflow to cdash reports in daily-build (#5004)
byrnHDF Oct 25, 2024
fdacb62
Remove duplicate sec2 VFD ID variable (#5013)
derobins Oct 25, 2024
bf805b5
Remove version number from h5repack test plugin (#5011)
derobins Oct 26, 2024
e08ae4e
Convert develop to v2.0.0 (#5006)
byrnHDF Oct 28, 2024
a33537a
Fix minor Windows warnings (#5021)
derobins Oct 28, 2024
c31fead
Clean up comments in FUNC_ENTER macros (#5019)
derobins Oct 28, 2024
f1b9098
Fix remaining calloc param reversals (#5018)
derobins Oct 28, 2024
6d3585c
bin/restore deleted checked-in files (#5017)
derobins Oct 28, 2024
dc98aaa
Fix bad private FUNC_ENTER macros (#5020)
derobins Oct 28, 2024
bd46ecc
Add workflow step to test expected test failures (#5023)
byrnHDF Oct 28, 2024
b15f2db
Add msys2 workflow for CMake (#4991)
byrnHDF Oct 28, 2024
54eb6a2
Fix segfault in h5dump caused by corrupted btree node level (#5002)
bmribler Oct 29, 2024
c5f5936
Rework FUNC_ENTER macros (#5024)
derobins Oct 29, 2024
45548e3
Add full-text search to Doxygen (#4994)
gheber Oct 29, 2024
db86c95
restore GH to site name (#5027)
byrnHDF Oct 29, 2024
3b97f2a
Add long double format option to h5dump (#5025)
byrnHDF Oct 29, 2024
91a128d
Remove Julia CI source patch (#5030)
derobins Oct 29, 2024
81e4330
Remove Autotools Cygwin PR action (#5031)
derobins Oct 29, 2024
68d2b79
Remove comment about multi VFD duplication (#5029)
derobins Oct 29, 2024
eca2f19
Verify CMake workflows match autotools (#5035)
byrnHDF Oct 29, 2024
66d86e0
Add HDF5 2.0 planning link to README.md (#5050)
derobins Oct 30, 2024
d0c206b
Add callable workflows for building OpenMPI and MPICH from source (#5…
jhendersonHDF Oct 30, 2024
1bce7ef
malloc --> calloc in H5B cache entry (#5053)
derobins Oct 31, 2024
0096eaf
Make H5T__free more aggressive about cleanup (#5054)
derobins Oct 31, 2024
61c7dda
Merge remote-tracking branch 'upstream/develop' into develop
brtnfld Oct 31, 2024
0e9f74f
Merge remote-tracking branch 'upstream/develop' into develop
brtnfld Nov 4, 2024
ca5e780
renamed H5VLstart_lib_state and H5VLfinish_lib_state, updated documen…
brtnfld Nov 4, 2024
9d5ab6b
Implement support for complex number datatypes (#4630)
jhendersonHDF Oct 31, 2024
cf9520f
Add parallel cdash script to daily-build workflow (#5032)
byrnHDF Nov 1, 2024
1076889
Check if mirror VFD and subfiling VFD are enabled before adding their…
lrknox Nov 1, 2024
bb49f9d
Update daily build action to build MPICH and OpenMPI from source (#5058)
jhendersonHDF Nov 1, 2024
97defff
Bump the github-actions group with 3 updates (#5061)
dependabot[bot] Nov 2, 2024
d356b6b
Fix parsing error of h(p)*c wrappers (#5060)
brtnfld Nov 2, 2024
c98ef30
Move hl example into HDF5Examples (#5057)
byrnHDF Nov 4, 2024
0e6bc48
Remove top-level structure from MPI source build workflow tar artifac…
jhendersonHDF Nov 4, 2024
79a634f
Update nvhpc version to 24.9 (#4993)
hyoklee Nov 4, 2024
dd38101
Add OSS-Fuzz badge (#5059)
hyoklee Nov 4, 2024
4d21fb1
Update stdio API calls (#5064)
derobins Nov 4, 2024
aefa4ba
Fixed H5Ovisit2() change of behavior between 1.10.11 and v1.14.4.3 (#…
bmribler Nov 4, 2024
017f0c6
Improve merge CI (#5066)
byrnHDF Nov 4, 2024
2637475
Merge remote-tracking branch 'upstream/develop' into develop
brtnfld Nov 4, 2024
b498aa0
updated RELEASE notes
brtnfld Nov 4, 2024
7370cd7
revert configure.ac changes
brtnfld Nov 4, 2024
defab4d
Merge branch 'develop' into H5VL_update
brtnfld Nov 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doxygen/aliases
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ ALIASES += op_data{1}="\param[in,out] \1 User-defined callback function context"
ALIASES += op_data_in="\param[in] op_data User-defined callback function context"
ALIASES += op_data_in{1}="\param[in] \1 User-defined callback function context"

ALIASES += vol_only_api="This routine is exclusively for authors of HDF5 VOL connectors. It is not part of the public HDF5 APIs for HDF5 application developers."

################################################################################
# Asynchronous
################################################################################
Expand Down
8 changes: 5 additions & 3 deletions release_docs/RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -345,9 +345,11 @@ New Features
- HDF5Examples/C/H5T/200/h5ex_t_complex_custom.c (Uses H5Tcomplex_create to create
a custom complex number type)

- The H5VLstart_lib_state / H5VLfinish_lib_state API routines for pass-
through connector authors now require a parameter that can be used to
store the library's context.
- FOR VOL DEVELOPERS: Renamed H5VLstart_lib_state and H5VLfinish_lib_state

The APIs H5VLstart_lib_state and H5VLfinish_lib_state have been renamed to
H5VLopen_lib_context and H5VLclose_lib_context, respectively, with the addition
of a "context" argument.

- Removed H5FDperform_init API routine. Virtual File Driver (VFD)
developers who wish to provide an ID for their driver should create
Expand Down
48 changes: 4 additions & 44 deletions src/H5VL.c
Original file line number Diff line number Diff line change
Expand Up @@ -768,27 +768,8 @@ H5VLretrieve_lib_state(void **state /*out*/)
FUNC_LEAVE_API_NOINIT(ret_value)
} /* H5VLretrieve_lib_state() */

/*---------------------------------------------------------------------------
* Function: H5VLstart_lib_state
*
* Purpose: Opens a new internal context for the HDF5 library. The context
* returned (via the OUT parameter) must be passed to
* H5VLfinish_lib_state to conclude the library's context and
* release resources.
*
* Note: This routine is _only_ for HDF5 VOL connector authors! It is
* _not_ part of the public API for HDF5 application developers.
*
* Note: Should probably rename this to 'H5VLopen_lib_context' or
* similar.
*
* Return: Success: Non-negative, *context set
* Failure: Negative, *context unset
*
*---------------------------------------------------------------------------
*/
herr_t
H5VLstart_lib_state(void **context)
H5VLopen_lib_context(void **context)
{
herr_t ret_value = SUCCEED; /* Return value */

Expand All @@ -805,7 +786,7 @@ H5VLstart_lib_state(void **context)

done:
FUNC_LEAVE_API_NOINIT(ret_value)
} /* H5VLstart_lib_state() */
} /* H5VLopen_lib_context() */

/*---------------------------------------------------------------------------
* Function: H5VLrestore_lib_state
Expand Down Expand Up @@ -840,29 +821,8 @@ H5VLrestore_lib_state(const void *state)
FUNC_LEAVE_API_NOINIT(ret_value)
} /* H5VLrestore_lib_state() */

/*---------------------------------------------------------------------------
* Function: H5VLfinish_lib_state
*
* Purpose: Closes the internal state of the HDF5 library, undoing the
* affects of H5VLstart_lib_state.
*
* Note: This routine is _only_ for HDF5 VOL connector authors! It is
* _not_ part of the public API for HDF5 application developers.
*
* Note: This routine must be called as a "pair" with
* H5VLstart_lib_state. It can be called before / after /
* independently of H5VLfree_lib_state.
*
* Note: Should probably rename this to 'H5VLclose_lib_context' or
* similar.
*
* Return: Success: Non-negative
* Failure: Negative
*
*---------------------------------------------------------------------------
*/
herr_t
H5VLfinish_lib_state(void *context)
H5VLclose_lib_context(void *context)
{
herr_t ret_value = SUCCEED; /* Return value */

Expand All @@ -879,7 +839,7 @@ H5VLfinish_lib_state(void *context)

done:
FUNC_LEAVE_API_NOINIT(ret_value)
} /* H5VLfinish_lib_state() */
} /* H5VLclose_lib_context() */

/*---------------------------------------------------------------------------
* Function: H5VLfree_lib_state
Expand Down
43 changes: 41 additions & 2 deletions src/H5VLconnector_passthru.h
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,48 @@ H5_DLL hid_t H5VLwrap_register(void *obj, H5I_type_t type);

/* Library context and state routines */
H5_DLL herr_t H5VLretrieve_lib_state(void **state);
H5_DLL herr_t H5VLstart_lib_state(void **context);
/**
* \ingroup H5VLDEV
*
* \brief Opens a new internal context for the HDF5 library.
*
* \param[out] context library's context
*
* \return Returns a non-negative value if \p *context is set; otherwise returns
* negative value if \p *context is unset.
*
* \details Opens a new internal context for the HDF5 library. The context
* returned (via the OUT parameter) must be passed to
* H5VLfinish_lib_state() to conclude the library's context and
* release resources.
*
* \note \vol_only_api
*
* \since 2.0.0
*
*/
H5_DLL herr_t H5VLopen_lib_context(void **context);
H5_DLL herr_t H5VLrestore_lib_state(const void *state);
H5_DLL herr_t H5VLfinish_lib_state(void *context);
/**
* \ingroup H5VLDEV
*
* \brief Closes the internal state of the HDF5 library.
*
* \param[in] context library's context
*
* \return \herr_t
*
* \details Closes the internal state of the HDF5 library, undoing the effects
* of H5VLstart_lib_state(). This function must be called as a \em pair
* with H5VLstart_lib_state(). It can be invoked before, after, or
* independently of H5VLfree_lib_state().
*
* \note \vol_only_api
*
* \since 2.0.0
*
*/
H5_DLL herr_t H5VLclose_lib_context(void *context);
H5_DLL herr_t H5VLfree_lib_state(void *state);

/* Pass-through callbacks */
Expand Down
Loading