Convert develop to v2.0.0 #5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Priority - 1. High 🔼
byrnHDF
requested review from
jhendersonHDF,
derobins,
brtnfld,
epourmal,
lrknox,
fortnern,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
lrknox
approved these changes
Oct 25, 2024
| @@ -36,7 +36,7 @@ CONTENTS | |||
|
|
|||
| - New Features | |||
| - Support for new platforms and languages | |||
| - Bug Fixes since HDF5-1.16.0 | |||
| - Bug Fixes since HDF5-2.0.0 | |||
There was a problem hiding this comment.
For a 2.0.0 release (assuming it's the next one), should this be "since HDF5-1.14.5"? Or possibly "Bug Fixes in this release"?
release_docs/INSTALL_Autotools.txt
Outdated
| @@ -81,23 +81,23 @@ III. Full installation instructions for source distributions | |||
| 1. Unpacking the distribution | |||
| The HDF5 source code is distributed in a variety of formats which | |||
| can be unpacked with the following commands, each of which creates an | |||
| 'hdf5-X.Y.Z' directory, where X.Y.Z is the HDF5 version numbers. | |||
| 'hdf5-2.X.Y' directory, where2. X.Y is the HDF5 version numbers. | |||
There was a problem hiding this comment.
Suggested change
| 'hdf5-2.X.Y' directory, where2. X.Y is the HDF5 version numbers. | |
| 'hdf5-2.X.Y' directory, where 2.X.Y is the HDF5 version number. |
There was a problem hiding this comment.
Or else where 2.X.Y are the version numbers.
release_docs/INSTALL_CMake.txt
Outdated
| @@ -113,7 +113,7 @@ To build HDF5 with the SZIP and ZLIB external libraries you will need to: | |||
|
|
|||
| The command above will configure, build, test, and create an install | |||
| package in the myhdfstuff folder. It will have the format: | |||
| HDF5-1.17.NN-<platform>.<zip or tar.gz> | |||
| HDF5-2.XX.YY-<platform>.<zip or tar.gz> | |||
There was a problem hiding this comment.
not a big deal, but why XX.YY here when all the others are X.Y?
jhendersonHDF
approved these changes
Oct 25, 2024
derobins
approved these changes
Oct 28, 2024
|
Update PR submitted: spack/spack#47299
It may take a few days to be merged.
Larry
…________________________________
From: H. Joe Lee ***@***.***>
Sent: Tuesday, October 29, 2024 10:27 AM
To: HDFGroup/hdf5 ***@***.***>
Cc: Larry Knox ***@***.***>; Mention ***@***.***>
Subject: Re: [HDFGroup/hdf5] Convert develop to v2.0.0 (PR #5006)
@byrnHDF<https://github.com/byrnHDF> , please revert h5py.yml change until @lrknox<https://github.com/lrknox> updates Spack package that matches your change.
—
Reply to this email directly, view it on GitHub<#5006 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADGMWCQR4BOXRLSHVUOPJITZ56SPDAVCNFSM6AAAAABQSB77LKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBUGYYDKMBYGY>.
You are receiving this because you were mentioned.
|
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Oct 31, 2024
Switches previous 1.16/17/18 values to 2.0
brtnfld
pushed a commit
to brtnfld/hdf5
that referenced
this pull request
Nov 4, 2024
Switches previous 1.16/17/18 values to 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the develop version to v2.0.0 and remove 1.16.0 and 1.18.0 references