Sync develop branch changes March 4 - 6 to hdf5_1_14 branch #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st (HDFGroup#4059) * Offset of a floating-point type also needs to be accounted for * Clarify ordering of H5Tset_precision and H5Tset_fields
…DFGroup#4061) H5Tset_fields did not account for any offset in a floating-point datatype, causing it to fail when a datatype's precision is correctly set such that it doesn't include the offset bits.
* Rename incorrectly named option * Restore the correct uses of USING_MEMCHECKER * Update release note
This was due to not freeing a test buffer. It was not a core library memory leak.
Compound fill values were set to the integer -1, causing valgrind to flag 'uninitialized bytes' errors. This is just a problem with the cmpd_dset test and not a core library problem.
This was due to a complex type fill value being set to -1 instead of a proper complex value. This was a test problem and not a core library issue.
lrknox
requested review from
brtnfld,
derobins,
epourmal,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
mattjala
as code owners
lrknox
added
Merge
lrknox
changed the title
byrnHDF
reviewed
Mar 12, 2024
.github/workflows/cmake-ctest.yml
Outdated
| @@ -273,7 +273,7 @@ jobs: | |||
| mkdir "${{ runner.workspace }}/build114/hdf5" | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING_LBNL_HDF5 ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/README.md ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/build114/${{ inputs.preset_name }}-Clang/README.md ${{ runner.workspace }}/build/hdf5 | |||
There was a problem hiding this comment.
"build/hdf5" SB "/build114/hdf5"
byrnHDF
reviewed
Mar 12, 2024
.github/workflows/cmake-ctest.yml
Outdated
| @@ -146,7 +146,7 @@ jobs: | |||
| mkdir "${{ runner.workspace }}/build114/hdf5" | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING_LBNL_HDF5 ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/README.md ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/build114/${{ inputs.preset_name }}-GNUC/README.md ${{ runner.workspace }}/build/hdf5 | |||
There was a problem hiding this comment.
"build/hdf5" SB "/build114/hdf5"
byrnHDF
reviewed
Mar 12, 2024
.github/workflows/cmake-ctest.yml
Outdated
| @@ -337,7 +337,7 @@ jobs: | |||
| mkdir "${{ runner.workspace }}/build114/hdf5" | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING_LBNL_HDF5 ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/README.md ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/build114/${{ inputs.preset_name }}-GNUC-S3/README.md ${{ runner.workspace }}/build/hdf5 | |||
There was a problem hiding this comment.
"build/hdf5" SB "/build114/hdf5"
byrnHDF
reviewed
Mar 12, 2024
.github/workflows/cmake-ctest.yml
Outdated
| @@ -422,7 +422,7 @@ jobs: | |||
| mkdir "${{ runner.workspace }}/build114/hdf5" | |||
| Copy-Item -Path ${{ runner.workspace }}/hdf5/hdfsrc/COPYING -Destination ${{ runner.workspace }}/build114/hdf5/ | |||
| Copy-Item -Path ${{ runner.workspace }}/hdf5/hdfsrc/COPYING_LBNL_HDF5 -Destination ${{ runner.workspace }}/build114/hdf5/ | |||
| Copy-Item -Path ${{ runner.workspace }}/hdf5/hdfsrc/README.md -Destination ${{ runner.workspace }}/build114/hdf5/ | |||
| Copy-Item -Path ${{ runner.workspace }}/hdf5/build114/${{ inputs.preset_name }}-Intel/README.md -Destination ${{ runner.workspace }}/build/hdf5/ | |||
There was a problem hiding this comment.
"build/hdf5" SB "/build114/hdf5"
byrnHDF
reviewed
Mar 12, 2024
.github/workflows/cmake-ctest.yml
Outdated
| @@ -501,7 +501,7 @@ jobs: | |||
| mkdir "${{ runner.workspace }}/build114/hdf5" | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/COPYING_LBNL_HDF5 ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/hdfsrc/README.md ${{ runner.workspace }}/build114/hdf5 | |||
| cp ${{ runner.workspace }}/hdf5/build114/${{ inputs.preset_name }}-Intel/README.md ${{ runner.workspace }}/build/hdf5 | |||
There was a problem hiding this comment.
"build/hdf5" SB "/build114/hdf5"
byrnHDF
reviewed
Mar 12, 2024
release_docs/INSTALL_CMake.txt
Outdated
| 2. Obtain HDF5 source from Github | ||
| development branch: https://github.com/HDFGroup/hdf5 | ||
| last release: https://github.com/HDFGroup/hdf5/releases/latest | ||
| hdf5-1_15_"X".tar.gz or hdf5-1_15_"X".zip |
byrnHDF
reviewed
Mar 12, 2024
release_docs/INSTALL_CMake.txt
Outdated
| ------------------------------------------------------------------------- | ||
| Individual files needed as mentioned in this document | ||
| ------------------------------------------------------------------------- | ||
| CMake build script from https://github.com/HDFGroup/hdf5/tree/master/config/cmake/scripts: |
There was a problem hiding this comment.
master SB hd5_1_14 (and below)
byrnHDF
reviewed
Mar 12, 2024
| NOTE: this file is available at the HDF web site: | ||
| https://portal.hdfgroup.org/display/support/Building+HDF5+with+CMake | ||
| NOTE: this file is available in the HDF5 repository, for more information see: | ||
| https://github.com/HDFGroup/hdf5/blob/develop/release_docs/USING_CMake_Examples.txt |
byrnHDF
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.