Add MSYS2 action #3861
Add MSYS2 action #3861
Conversation
hyoklee
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala and
brtnfld
as code owners
derobins
added
Merge - To 1.14
Priority - 1. High 🔼
| cd hdf5 | ||
| mkdir build | ||
| cd build | ||
| cmake -DH5_HAVE_ALARM:INTERNAL=0 -DH5_HAVE_ASPRINTF:INTERNAL=0 -DH5_HAVE_VASPRINTF:INTERNAL=0 .. |
There was a problem hiding this comment.
We should probably move the alarm, asprintf, and vasprintf checks in CMake so they check on Windows (I'm assuming they are not checked on Win32).
There was a problem hiding this comment.
Interestingly, they are run all the time. We'll need to figure out why they are not being detected on Windows w/ MSYS2.
| git clone https://github.com/HDFgroup/hdf5.git | ||
| cd hdf5 | ||
| mkdir build | ||
| cd build |
There was a problem hiding this comment.
Please add steps between configure, build and test
| @@ -0,0 +1,57 @@ | |||
| name: msys2 | |||
There was a problem hiding this comment.
Change name to match other yml files and add job name with matrix.sys variable
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: |
There was a problem hiding this comment.
At only 12 mins of time we should make this a callable workflow from the cmake.yml.
| cd hdf5 | ||
| mkdir build | ||
| cd build | ||
| cmake -DH5_HAVE_ALARM:INTERNAL=0 -DH5_HAVE_ASPRINTF:INTERNAL=0 -DH5_HAVE_VASPRINTF:INTERNAL=0 .. |
There was a problem hiding this comment.
Is there is a reason to not use the same configure / build / test steps we use in other CMake yml files?
|
We should fix the issues raised here and then create a solution that addresses all the issues for MSYS testing. |
|
Superseded by #3938 |
Some tests fail on all 4 environments.
However, compilation works fine.
clang17 environment needs extra definitions.