Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check return values from HDF5 API calls. #3556

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Check return values from HDF5 API calls. #3556

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3deef67
Check return values from HDF5 API calls.
hyoklee Sep 20, 2023
41c56bd
Address @jhendersonHDF review
hyoklee Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions testpar/t_init_term.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ main(int argc, char **argv)

MPI_Finalize();

nerrors += GetTestNumErrs();

/* test if we can initialize the library with MPI being finalized
and create a file serially */
H5open();
if (H5open() < 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use the VRFY macro for these checks since it's consistent and will increment nerrors on failure

nerrors = nerrors + 1;
}

if (mpi_rank == 0) {
char filename[1024];
Expand All @@ -54,7 +54,9 @@ main(int argc, char **argv)
file_id = -1;
}

H5close();
if (H5close() < 0) {
nerrors = nerrors + 1;
}

if (MAINPROCESS) {
if (0 == nerrors)
Expand Down