Add test for H5Fget_obj_count with datatypes #3313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattjala
added
Merge - To 1.10
Priority - 2. Medium ⏹
mattjala
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
brtnfld
as code owners
byrnHDF
approved these changes
Aug 1, 2023
mattjala
force-pushed
the
test_get_datatype_count
branch
2 times, most recently
from
58825df
to
6d9525a
Compare
|
It's hard to tell exactly since the line numbers in CI builds don't seem to match up with the changes here, but based on the failure output it looks like this test is failing as expected. We should test this same change against 1.10 now to see if it fails in the same way. |
mattjala
force-pushed
the
test_get_datatype_count
branch
from
b819f9b
to
ab901bc
Compare
I ran the same test on 1.10.10 locally, and it fails in the same way. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing tests for this function are pretty sparse, especially with respect to datatypes.
This is expected to reveal an issue where, when counting the objects in all files, copies of transient datatypes are counted as open objects. Expected behavior is that only committed datatypes are counted as objects.