Skip to content

Commit

Permalink
Get the Autotools version number from H5public.h (#5009)
Browse files Browse the repository at this point in the history
The version number in the Autotools is scraped from README.md in configure.ac, which makes README.md count as 'code', which is a problem since changes to markdown files are ignored in CI.

This change scrapes the version number from H5public.h instead
of README.md.
  • Loading branch information
derobins authored Oct 25, 2024
1 parent 6122828 commit c93b3c4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
HDF5 version 1.17.0 currently under development
HDF5 version 2.0.0 currently under development

![HDF5 Logo](doxygen/img/HDF5.png)

Expand Down
5 changes: 3 additions & 2 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -4024,8 +4024,9 @@ fi
## and installed with the libraries (used to generate libhdf5.settings).
##

## HDF5 version from the first line of the README.md file.
H5_VERSION="`cut -d' ' -f3 $srcdir/README.md | head -1`"
## HDF5 version from H5public.h (3rd field of #define H5_VERS_STR "1.17.0"
## w/ sed to remove quotes).
H5_VERSION=`grep 'H5_VERS_STR' $srcdir/src/H5public.h | sed s/\"//g | cut -d' ' -f3`
AC_SUBST([H5_VERSION])

## Configuration date
Expand Down

0 comments on commit c93b3c4

Please sign in to comment.