Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled check that sum of relative grades is 100 #3

Merged

Conversation

Stivanification
Copy link
Contributor

Hey, first of all thanks for your work on this package! It's very useful to me. However, I don't like the constraint that the sum of the relative grades must sum to 100. Whenever that is the case, one can obtain 100% of the points for the question by simply marking every option as correct. If relative grades are not allowed to assume negative values, that will always be the case. I therefore made the following small changes to the package:

  • Allow relative grades to be integers between -100 and 100
  • Instead of checking that the sum of the relative grades of all answers is 100, check that the sum of the relative grades of the correct answers is 100

I felt that this would be more reasonable default behavior, so I submitted this pull request.

@Guillaume-Garrigos
Copy link
Owner

Hi Stefan, (sorry for the late answer)

Thanks for your comments. You are right about negative values, I didn't pay attention to it since I mainly use the option "one anwser only".

Before this weekend (I think) I will inlude this in the code, together with correcting the bug about TexSoup #2

@Guillaume-Garrigos Guillaume-Garrigos merged commit 0ceb391 into Guillaume-Garrigos:master Nov 19, 2020
@Stivanification Stivanification deleted the change_MC_eval branch November 19, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants