Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-router-dom 6.26.1 → 6.26.2 (patch) #241

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 10, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ react-router-dom (6.26.1 → 6.26.2) · Repo · Changelog

Release Notes

6.26.2 (from changelog)

Date: 2024-09-09

Patch Changes

  • Update the unstable_dataStrategy API to allow for more advanced implementations (#11943)
    • ⚠️ If you have already adopted unstable_dataStrategy, please review carefully as this includes breaking changes to this API
    • Rename unstable_HandlerResult to unstable_DataStrategyResult
    • Change the return signature of unstable_dataStrategy from a parallel array of unstable_DataStrategyResult[] (parallel to matches) to a key/value object of routeId => unstable_DataStrategyResult
      • This allows more advanced control over revalidation behavior because you can opt-into or out-of revalidating data that may not have been revalidated by default (via match.shouldLoad)
    • You should now return/throw a result from your handlerOverride instead of returning a DataStrategyResult
      • The return value (or thrown error) from your handlerOverride will be wrapped up into a DataStrategyResult and returned fromm match.resolve
      • Therefore, if you are aggregating the results of match.resolve() into a final results object you should not need to think about the DataStrategyResult type
      • If you are manually filling your results object from within your handlerOverride, then you will need to assign a DataStrategyResult as the value so React Router knows if it's a successful execution or an error (see examples in the documentation for details)
    • Added a new fetcherKey parameter to unstable_dataStrategy to allow differentiation from navigational and fetcher calls
  • Preserve opted-in view transitions through redirects (#11925)
  • Preserve pending view transitions through a router revalidation call (#11917)
  • Fix blocker usage when blocker.proceed is called quickly/synchronously (#11930)

Full Changelog: v6.26.1...v6.26.2

Does any of this look wrong? Please let us know.

↗️ react-router (indirect, 6.26.1 → 6.26.2) · Repo · Changelog

Release Notes

6.26.2 (from changelog)

Date: 2024-09-09

Patch Changes

  • Update the unstable_dataStrategy API to allow for more advanced implementations (#11943)
    • ⚠️ If you have already adopted unstable_dataStrategy, please review carefully as this includes breaking changes to this API
    • Rename unstable_HandlerResult to unstable_DataStrategyResult
    • Change the return signature of unstable_dataStrategy from a parallel array of unstable_DataStrategyResult[] (parallel to matches) to a key/value object of routeId => unstable_DataStrategyResult
      • This allows more advanced control over revalidation behavior because you can opt-into or out-of revalidating data that may not have been revalidated by default (via match.shouldLoad)
    • You should now return/throw a result from your handlerOverride instead of returning a DataStrategyResult
      • The return value (or thrown error) from your handlerOverride will be wrapped up into a DataStrategyResult and returned fromm match.resolve
      • Therefore, if you are aggregating the results of match.resolve() into a final results object you should not need to think about the DataStrategyResult type
      • If you are manually filling your results object from within your handlerOverride, then you will need to assign a DataStrategyResult as the value so React Router knows if it's a successful execution or an error (see examples in the documentation for details)
    • Added a new fetcherKey parameter to unstable_dataStrategy to allow differentiation from navigational and fetcher calls
  • Preserve opted-in view transitions through redirects (#11925)
  • Preserve pending view transitions through a router revalidation call (#11917)
  • Fix blocker usage when blocker.proceed is called quickly/synchronously (#11930)

Full Changelog: v6.26.1...v6.26.2

Does any of this look wrong? Please let us know.

🗑️ string-width-cjs (removed)

🗑️ strip-ansi-cjs (removed)

🗑️ wrap-ansi-cjs (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Sep 10, 2024
Copy link

semanticdiff-com bot commented Sep 10, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Filename Status
✔️ POCUploadStream/ClientApp/package-lock.json 62.54% smaller
✔️ POCUploadStream/ClientApp/package.json Analyzed

Copy link

korbit-ai bot commented Sep 10, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

👋 Hi there!

  1. Ensure consistent indentation and formatting for the added dependencies.
  2. Verify if the new dependencies align with project requirements and do not introduce security vulnerabilities.
  3. Check if any existing dependencies need to be updated or removed for compatibility or performance reasons.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. string-width-cjs and strip-ansi-cjs packages have been added redundantly in the package-lock.json file without any apparent need after the updates.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. package-lock.json:
    • It's redundant to have string-width-cjs and strip-ansi-cjs packages added in the package-lock.json file as they are mentioned multiple times without a clear reason. It's recommended to ensure these packages are only listed once if they are essential.
  2. package.json:
    • It's good practice to ensure that the versions of packages listed in package.json are updated alongside their corresponding updates in package-lock.json. Make sure the versions are synchronized for consistency and to avoid potential dependency conflicts.

Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

coderabbitai bot commented Sep 10, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

gooroo-dev bot commented Sep 10, 2024

Please double check the following review of the pull request:

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

  • 🛠️ Updated react-router-dom from version 6.26.1 to 6.26.2.
  • 🛠️ Updated @remix-run/router from version 1.19.1 to 1.19.2.
  • ➕ Added new dependencies: color-convert and color-name.
  • ➕ Added new dependencies: string-width-cjs and strip-ansi-cjs.
  • ➕ Added new dependencies: wrap-ansi-cjs.
  • ➖ Removed redundant dependencies: string-width-cjs, strip-ansi-cjs, and wrap-ansi-cjs.

Identified Issues

ID Type Details Severity Confidence
1 💪Best Practices Ensure that the new dependencies are necessary and not redundant. 🟡Low 🟠Medium

Issue 1: Ensure that the new dependencies are necessary and not redundant.

Details:
The new dependencies added (color-convert, color-name, string-width-cjs, strip-ansi-cjs, wrap-ansi-cjs) should be verified to ensure they are necessary and not redundant. This is to avoid unnecessary bloat in the package-lock.json file.

Suggested Fix:
Review the necessity of the newly added dependencies and remove any that are not required.

Code to Address the Issue:

{
  "dependencies": {
    "color-convert": "2.0.1",
    "color-name": "1.1.4",
    "string-width-cjs": "npm:[email protected]",
    "strip-ansi-cjs": "npm:[email protected]",
    "wrap-ansi-cjs": "npm:[email protected]"
  }
}

Explanation:
The suggested fix involves reviewing the necessity of the new dependencies added in the package-lock.json file. If any of these dependencies are found to be redundant, they should be removed to keep the project dependencies clean and minimal.

Missing Tests

Since the changes primarily involve updating package versions and adding/removing dependencies, no specific code-level tests are required. However, it is advisable to run the existing test suite to ensure that the updates do not introduce any regressions or issues.

Summon me to re-review when updated! Yours, Gooroo.dev
Please reply or add a reaction to this review.

Copy link

instapr bot commented Sep 10, 2024

Feedback:

  • Update on react-router-dom to version 6.26.2:
    • Changes include updating color-convert to 2.0.1 and color-name to 1.1.4.
    • The strip-ansi-cjs, string-width-cjs, strip-ansi-cjs, and wrap-ansi-cjs dependencies have also been updated accordingly.
  • Ensure all dependencies are compatible with the updated versions.

This looks good overall. Make sure to verify compatibility with other dependencies with the updated versions.

@guibranco guibranco enabled auto-merge (squash) September 10, 2024 18:13
@gstraccini gstraccini bot added the ☑️ auto-merge Auto-merge enabled by gstraccini-bot label Sep 10, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@remix-run/[email protected] network 0 2.72 MB mjackson

🚮 Removed packages: npm/@remix-run/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Sep 10, 2024
@guibranco
Copy link
Member

@depfu merge

Copy link

Infisical secrets check: ✅ No secrets leaked!

Scan results:

6:13PM INF scanning for exposed secrets...
6:13PM INF 237 commits scanned.
6:13PM INF scan completed in 953ms
6:13PM INF no leaks found

Copy link

sonarcloud bot commented Sep 10, 2024

@guibranco guibranco merged commit 3155f9b into main Sep 10, 2024
18 checks passed
@guibranco guibranco deleted the depfu/update/POCUploadStreamClientApp/npm/react-router-dom-6.26.2 branch September 10, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Auto-merge enabled by gstraccini-bot 🤖 bot Issue/Pull request created by bot depfu size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant