Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump webpack from 5.76.1 to 5.94.0 in /POCUploadStream/ClientApp in the npm_and_yarn group across 1 directory #239

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 30, 2024

Bumps the npm_and_yarn group with 1 update in the /POCUploadStream/ClientApp directory: webpack.

Updates webpack from 5.76.1 to 5.94.0

Release notes

Sourced from webpack's releases.

v5.94.0

Bug Fixes

  • Added runtime condition for harmony reexport checked
  • Handle properly data/http/https protocols in source maps
  • Make bigint optimistic when browserslist not found
  • Move @​types/eslint-scope to dev deps
  • Related in asset stats is now always an array when no related found
  • Handle ASI for export declarations
  • Mangle destruction incorrect with export named default properly
  • Fixed unexpected asi generation with sequence expression
  • Fixed a lot of types

New Features

  • Added new external type "module-import"
  • Support webpackIgnore for new URL() construction
  • [CSS] @import pathinfo support

Security

  • Fixed DOM clobbering in auto public path

v5.93.0

Bug Fixes

  • Generate correct relative path to runtime chunks
  • Makes DefinePlugin quieter under default log level
  • Fixed mangle destructuring default in namespace import
  • Fixed consumption of eager shared modules for module federation
  • Strip slash for pretty regexp
  • Calculate correct contenthash for CSS generator options

New Features

  • Added the binary generator option for asset modules to explicitly keep source maps produced by loaders
  • Added the modern-module library value for tree shakable output
  • Added the overrideStrict option to override strict or non-strict mode for javascript modules

v5.92.1

Bug Fixes

  • Doesn't crash with an error when the css experiment is enabled and contenthash is used

v5.92.0

Bug Fixes

  • Correct tidle range's comutation for module federation
  • Consider runtime for pure expression dependency update hash
  • Return value in the subtractRuntime function for runtime logic

... (truncated)

Commits
  • eabf85d chore(release): 5.94.0
  • 955e057 security: fix DOM clobbering in auto public path
  • 9822387 test: fix
  • cbb86ed test: fix
  • 5ac3d7f fix: unexpected asi generation with sequence expression
  • 2411661 security: fix DOM clobbering in auto public path
  • b8c03d4 fix: unexpected asi generation with sequence expression
  • f46a03c revert: do not use heuristic fallback for "module-import"
  • 60f1898 fix: do not use heuristic fallback for "module-import"
  • 66306aa Revert "fix: module-import get fallback from externalsPresets"
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Description by Korbit AI

What change is being made?

Bump the webpack dependency from version 5.76.1 to 5.94.0 in the POCUploadStream/ClientApp directory, along with updating related dependencies and removing deprecated packages.

Why are these changes being made?

These changes are made to ensure the project uses the latest stable version of webpack, which includes performance improvements, bug fixes, and new features. Updating dependencies helps maintain compatibility and security, while removing deprecated packages reduces potential vulnerabilities and maintenance overhead.

Bumps the npm_and_yarn group with 1 update in the /POCUploadStream/ClientApp directory: [webpack](https://github.com/webpack/webpack).


Updates `webpack` from 5.76.1 to 5.94.0
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.76.1...v5.94.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Aug 30, 2024
Copy link

semanticdiff-com bot commented Aug 30, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Filename Status
✔️ POCUploadStream/ClientApp/package-lock.json 49.56% smaller

Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

korbit-ai bot commented Aug 30, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Your free trial of Korbit Pro is ending in 6 days. To continue using Pro, manage your subscription in the Korbit Console. Otherwise your account will be set to Korbit Starter beginning on September 5th, 2024.

Copy link

pr-code-reviewer bot commented Aug 30, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

Copy link

Potential issues, bugs, and flaws:

  1. @webassemblyjs/ast and its related dependencies have been removed in the package-lock.json file. This might lead to compatibility issues or missing functionality required by the application.

Code suggestions and improvements:

  1. Ensure that the removal of @webassemblyjs/ast and related dependencies is intentional and does not affect the functionality or compatibility of the application.
  2. Verify if any other parts of the codebase are dependent on the removed packages and update accordingly.
  3. Regularly update and review dependencies to avoid deprecated or unsupported packages that might introduce vulnerabilities.

Copy link

coderabbitai bot commented Aug 30, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (1)
  • POCUploadStream/ClientApp/package-lock.json is excluded by !**/package-lock.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@guibranco guibranco enabled auto-merge (squash) August 30, 2024 10:55
Copy link

instapr bot commented Aug 30, 2024

Feedback

The PR looks good. The update from webpack version 5.76.1 to 5.94.0 includes necessary changes. The release notes and commits have been reviewed.

No further action is needed. Great job!

@gstraccini gstraccini bot added the ☑️ auto-merge Auto-merge enabled by gstraccini-bot label Aug 30, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Aug 30, 2024
Copy link

gooroo-dev bot commented Aug 30, 2024

Please double check the following review of the pull request:

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

  • ➖ Removed @types/eslint-scope dependency.
  • ➖ Removed several @webassemblyjs dependencies (e.g., @webassemblyjs/ast, @webassemblyjs/helper-buffer, etc.).
  • ➖ Removed acorn-import-assertions dependency.
  • ➖ Removed enhanced-resolve dependency.
  • ➖ Removed es-module-lexer dependency.
  • ➖ Removed watchpack dependency.
  • ➕ Added acorn-import-attributes dependency.
  • ➕ Added new versions of several @webassemblyjs dependencies (e.g., @webassemblyjs/ast, @webassemblyjs/helper-buffer, etc.).
  • ➕ Added new versions of enhanced-resolve, es-module-lexer, and watchpack.
  • 🛠️ Updated webpack from version 5.76.1 to 5.94.0.
  • 🛠️ Updated several other dependencies to newer versions (e.g., browserslist, graceful-fs, etc.).

Identified Issues

ID Type Details Severity Confidence
1 💪Best Practices Ensure all removed dependencies are not required by other parts of the project 🟠Medium 🟠Medium
2 🚨Security Verify the integrity of new dependencies to ensure no vulnerabilities 🔴High 🟠Medium

Issue 1: Ensure all removed dependencies are not required by other parts of the project

Details:
The removal of dependencies such as @types/eslint-scope, @webassemblyjs packages, acorn-import-assertions, enhanced-resolve, es-module-lexer, and watchpack should be verified to ensure they are not required by other parts of the project.

Fix:
Review the project's codebase and ensure that none of the removed dependencies are used. If they are required, re-add them to the package-lock.json.

Issue 2: Verify the integrity of new dependencies to ensure no vulnerabilities

Details:
New dependencies and updated versions should be checked for any known vulnerabilities. This includes acorn-import-attributes, @webassemblyjs packages, enhanced-resolve, es-module-lexer, watchpack, and others.

Fix:
Use tools like npm audit or yarn audit to check for vulnerabilities in the new dependencies. Address any reported issues by updating or replacing the affected packages.

Missing Tests

Given that the primary changes are dependency updates, tests should focus on ensuring that the application still functions correctly with the new versions. Here are some general test cases:

  1. Build Process:

    • Verify that the application builds successfully without errors.
    • Ensure that the build output is as expected.
  2. Functionality Tests:

    • Run existing unit tests to ensure no functionality is broken.
    • Perform manual testing of critical paths in the application to ensure they work as expected.
  3. Performance Tests:

    • Measure the build time and runtime performance to ensure there are no regressions.
  4. Security Tests:

    • Run security scanning tools to ensure no new vulnerabilities are introduced.
# Example commands to run tests and audits
npm run build
npm test
npm audit

By following these steps, we can ensure that the dependency updates do not introduce any issues into the project.

Summon me to re-review when updated! Yours, Gooroo.dev
React or reply to keep the conversation going!

@guibranco
Copy link
Member

@dependabot squash and merge

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

Copy link

Infisical secrets check: ✅ No secrets leaked!

Scan results:

10:56AM INF scanning for exposed secrets...
10:56AM INF 235 commits scanned.
10:56AM INF scan completed in 909ms
10:56AM INF no leaks found

Copy link

Report too large to display inline

View full report↗︎

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 30, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link

Report is too large to display inline.
View full report↗︎

Next steps

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@guibranco guibranco merged commit b70bfab into main Aug 30, 2024
13 of 14 checks passed
@guibranco guibranco deleted the dependabot/npm_and_yarn/POCUploadStream/ClientApp/npm_and_yarn-7aabbe6aff branch August 30, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Auto-merge enabled by gstraccini-bot 🤖 bot Issue/Pull request created by bot dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code korbit-code-analysis size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant