Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-router-dom 6.26.0 → 6.26.1 (patch) #235

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Aug 16, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ react-router-dom (6.26.0 → 6.26.1) · Repo · Changelog

Release Notes

6.26.1 (from changelog)

Date: 2024-08-15

Patch Changes

  • Rename unstable_patchRoutesOnMiss to unstable_patchRoutesOnNavigation to match new behavior (#11888)
  • Update unstable_patchRoutesOnNavigation logic so that we call the method when we match routes with dynamic param or splat segments in case there exists a higher-scoring static route that we've not yet discovered (#11883)
    • We also now leverage an internal FIFO queue of previous paths we've already called unstable_patchRoutesOnNavigation against so that we don't re-call on subsequent navigations to the same path

Full Changelog: v6.26.0...v6.26.1

Does any of this look wrong? Please let us know.

↗️ react-router (indirect, 6.26.0 → 6.26.1) · Repo · Changelog

Release Notes

6.26.1 (from changelog)

Date: 2024-08-15

Patch Changes

  • Rename unstable_patchRoutesOnMiss to unstable_patchRoutesOnNavigation to match new behavior (#11888)
  • Update unstable_patchRoutesOnNavigation logic so that we call the method when we match routes with dynamic param or splat segments in case there exists a higher-scoring static route that we've not yet discovered (#11883)
    • We also now leverage an internal FIFO queue of previous paths we've already called unstable_patchRoutesOnNavigation against so that we don't re-call on subsequent navigations to the same path

Full Changelog: v6.26.0...v6.26.1

Does any of this look wrong? Please let us know.

🆕 string-width-cjs (added, npm:[email protected])

🆕 strip-ansi-cjs (added, npm:[email protected])

🆕 wrap-ansi-cjs (added, npm:[email protected])


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Description by Korbit AI

What change is being made?

Update react-router-dom from version 6.26.0 to 6.26.1 in package.json and package-lock.json.

Why are these changes being made?

This update includes minor bug fixes and improvements to react-router-dom and its dependencies, ensuring better stability and performance for the application.

Summary by CodeRabbit

  • Chores
    • Updated the react-router-dom package to version 6.26.1, ensuring improved performance and minor bug fixes without introducing breaking changes.

@depfu depfu bot added the depfu label Aug 16, 2024
Copy link

semanticdiff-com bot commented Aug 16, 2024

Review changes with SemanticDiff.

Analyzed 2 of 2 files.

Filename Status
✔️ POCUploadStream/ClientApp/package-lock.json 55.89% smaller
✔️ POCUploadStream/ClientApp/package.json Analyzed

Copy link

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

korbit-ai bot commented Aug 16, 2024

My review is in progress 📖 - I will have feedback for you in a few minutes!

Copy link

pr-code-reviewer bot commented Aug 16, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior:

  1. package-lock.json:

    • Removing dependencies such as color-convert and color-name may cause compatibility issues with other packages that rely on them.
    • In the removal of string-width-cjs, it seems its dependencies are also removed, which could break other parts of the application expecting those packages.
  2. package-lock.json:

    • Unnecessarily deleting strip-ansi-cjs and wrap-ansi-cjs without clear reasons, this can lead to unexpected behavior if these packages are needed elsewhere in the project.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency:

  1. package.json:
    • Update the version of react-router-dom to 6.26.1 to match the changes in package-lock.json for consistency.
    • Consider revisiting the dependencies and ensuring that packages removed from package-lock.json are intentionally eliminated to prevent any future issues.
    • Be consistent in dependency versioning across package.json and package-lock.json to avoid potential conflicts.

Copy link

coderabbitai bot commented Aug 16, 2024

Walkthrough

The recent change involves a minor version update of the react-router-dom package in the project's package.json. This update shifts the dependency from version ^6.26.0 to ^6.26.1, likely providing bug fixes, performance enhancements, and minor improvements without introducing breaking changes. The overall project structure and functionality remain intact.

Changes

Files Change Summary
POCUploadStream/ClientApp/package.json Updated react-router-dom from ^6.26.0 to ^6.26.1

Poem

In the code where bunnies hop,
A little change, a tiny swap.
React routes now dance anew,
With fixes small, yet oh so true.
Let's celebrate with joy and cheer,
For smoother paths are finally here! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

instapr bot commented Aug 16, 2024

Feedback:

Copy link

gooroo-dev bot commented Aug 16, 2024

Please double check the following review of the pull request:

Issues counts

🐞Mistake 🤪Typo 🚨Security 🚀Performance 💪Best Practices 📖Readability ❓Others
0 0 0 0 0 0 0

Changes in the diff

  • 🛠️ Updated react-router-dom from version 6.26.0 to 6.26.1.
  • 🛠️ Updated react-router from version 6.26.0 to 6.26.1.
  • 🛠️ Updated @remix-run/router from version 1.19.0 to 1.19.1.
  • ➖ Removed dependencies related to color-convert, color-name, string-width-cjs, strip-ansi-cjs, and wrap-ansi-cjs.
  • ➕ Re-added dependencies related to string-width-cjs, strip-ansi-cjs, and wrap-ansi-cjs.

Identified Issues

ID Type Details Severity Confidence
1 💪Best Practices Ensure that all removed dependencies are not required by other packages 🟠Medium 🟠Medium

Issue 1: Ensure that all removed dependencies are not required by other packages

Explanation

The diff shows the removal of several dependencies related to color-convert, color-name, string-width-cjs, strip-ansi-cjs, and wrap-ansi-cjs. It's important to ensure that these dependencies are not required by other packages in the project to avoid runtime errors.

Code to Address the Issue

No specific code change needed. Instead, perform the following steps:

  1. Audit Dependencies: Run npm ls to list all dependencies and ensure no other packages require the removed dependencies.
  2. Test Thoroughly: Run the project's test suite to ensure no functionality is broken due to the removal of these dependencies.
  3. Manual Verification: Manually check the package.json and package-lock.json files to verify no other dependencies are indirectly requiring the removed packages.

Explanation of the Fix

By auditing the dependencies and running tests, you can ensure that the removal of these dependencies does not negatively impact the project. This step is crucial for maintaining the stability and reliability of the application.

Missing Tests

Given the nature of the changes (dependency updates and removals), the following tests should be conducted:

  1. Unit Tests:

    • Ensure all existing unit tests pass without any issues.
    • Add unit tests to cover any new functionality introduced by the updated dependencies.
  2. Integration Tests:

    • Run integration tests to ensure that the updated react-router-dom, react-router, and @remix-run/router work seamlessly with the rest of the application.
  3. Manual Testing:

    • Manually test key functionalities of the application that rely on routing to ensure they work as expected.

By following these steps, you can confidently update the dependencies while ensuring the stability and functionality of the application.

Summon me to re-review when updated! Yours, Gooroo.dev
Feel free to react or reply to this review!

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@remix-run/[email protected] network 0 2.69 MB mjackson
npm/@types/[email protected] None 0 3 kB types
npm/@types/[email protected] None 0 3.57 kB types
npm/@types/[email protected] None 0 3.56 MB types
npm/@types/[email protected] None 0 2.74 kB types
npm/@types/[email protected] None 0 49.1 kB types
npm/@types/[email protected] None 0 32.2 kB types
npm/@types/[email protected] None 0 7 kB types
npm/@types/[email protected] None 0 5.05 kB types
npm/@types/[email protected] None 0 7.69 kB types
npm/@types/[email protected] None 0 7.65 kB types
npm/@types/[email protected] None 0 23.5 kB types
npm/@types/[email protected] None 0 5.19 kB types
npm/@types/[email protected] None 0 7.75 kB types
npm/@types/[email protected] None 0 5.84 kB types
npm/@types/[email protected] None 0 8.3 kB types
npm/@types/[email protected] None 0 20.8 kB types
npm/@types/[email protected] None 0 53.1 kB types
npm/@typescript-eslint/[email protected] None 0 2.27 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 4.89 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 17.9 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 580 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 86.2 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 217 kB jameshenry
npm/@typescript-eslint/[email protected] environment, filesystem 0 520 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 495 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 18.4 kB jameshenry
npm/@webassemblyjs/[email protected] None 0 201 kB xtuc
npm/@webassemblyjs/[email protected] None 0 6.37 kB xtuc
npm/@webassemblyjs/[email protected] None 0 6.25 kB xtuc
npm/@webassemblyjs/[email protected] None 0 8.7 kB xtuc
npm/@webassemblyjs/[email protected] None 0 10.4 kB xtuc
npm/@webassemblyjs/[email protected] None 0 32.4 kB xtuc
npm/@webassemblyjs/[email protected] None 0 19 kB xtuc
npm/@webassemblyjs/[email protected] None 0 5.32 kB xtuc
npm/@webassemblyjs/[email protected] None 0 46.3 kB xtuc
npm/@webassemblyjs/[email protected] None 0 11.3 kB xtuc
npm/@webassemblyjs/[email protected] None 0 29.4 kB xtuc
npm/@webassemblyjs/[email protected] None 0 23.9 kB xtuc
npm/@webassemblyjs/[email protected] None 0 9.34 kB xtuc
npm/@webassemblyjs/[email protected] None 0 124 kB xtuc
npm/@webassemblyjs/[email protected] None 0 37.4 kB xtuc
npm/@xtuc/[email protected] None 0 8.57 kB xtuc
npm/@xtuc/[email protected] None 0 190 kB xtuc
npm/[email protected] None 0 10.4 kB jeffcarp
npm/[email protected] None 0 9.1 kB timothygu
npm/[email protected] None 0 25.5 kB xtuc
npm/[email protected] None 0 45.3 kB goto-bus-stop
npm/[email protected] None 0 100 kB marijn
npm/[email protected] None 0 467 kB marijn
npm/[email protected] environment, filesystem, shell 0 15.4 kB fengmk2
npm/[email protected] filesystem 0 42 kB bholloway
npm/[email protected] None 0 34.6 kB tootallnate
npm/[email protected] None 0 52.2 kB esp
npm/[email protected] None 0 72.9 kB esp
npm/[email protected] None 0 20.1 kB mahdyar
npm/[email protected] None 0 9.37 kB sindresorhus
npm/[email protected] None 0 13.7 kB leerobinson
npm/[email protected] None 0 123 kB jessebeach
npm/[email protected] None 0 6.24 kB blakeembrey
npm/[email protected] None 0 30.7 kB ljharb
npm/[email protected] None 0 3.17 kB sindresorhus
npm/[email protected] None 0 18.2 kB ljharb
npm/[email protected] None 0 18.6 kB ljharb
npm/[email protected] None 0 18.1 kB ljharb
npm/[email protected] None 0 125 kB kyldvs
npm/[email protected] None 0 821 kB hargasinski
npm/[email protected] None 0 27.4 kB alexindigo
npm/[email protected] None 0 2.63 kB ryanzim
npm/[email protected] environment 0 199 kB ai
npm/[email protected] None 0 2.14 MB npmdeque
npm/[email protected] None 0 94.1 kB jessebeach
npm/[email protected] environment 0 14.4 kB simenb
npm/[email protected] filesystem 0 42.2 kB nicolo-ribaudo
npm/[email protected] environment, filesystem, shell 0 25.7 kB oss-bot
npm/[email protected] None 0 13.7 kB simenb
npm/[email protected] None 0 38 kB kentcdodds
npm/[email protected] None 0 4.47 kB iansu

🚮 Removed packages: npm/@remix-run/[email protected]

View full report↗︎

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code and did not find any issues!


Please note that I can make mistakes, and you should still encourage your team to review your code as well.

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
New author npm/[email protected] 🚫
Shell access npm/[email protected] 🚫
Deprecated npm/[email protected]
  • Reason: Use your platform's native atob() and btoa() methods instead
🚫
Unmaintained npm/[email protected]
  • Last Publish: 6/14/2016, 6:29:05 PM
🚫
Trivial Package npm/[email protected] 🚫
Unmaintained npm/@xtuc/[email protected]
  • Last Publish: 2/18/2019, 8:20:26 AM
🚫
Unmaintained npm/@xtuc/[email protected]
  • Last Publish: 7/19/2018, 4:10:45 PM
🚫
Filesystem access npm/[email protected] 🚫
Dynamic require npm/[email protected] 🚫
Dynamic require npm/[email protected] 🚫
Floating dependency npm/@types/[email protected] 🚫
Floating dependency npm/@types/[email protected] 🚫
Dynamic require npm/@typescript-eslint/[email protected] 🚫
Dynamic require npm/@typescript-eslint/[email protected] 🚫
Filesystem access npm/@typescript-eslint/[email protected] 🚫
Environment variable access npm/@typescript-eslint/[email protected] 🚫
Environment variable access npm/@typescript-eslint/[email protected] 🚫
Environment variable access npm/@typescript-eslint/[email protected] 🚫
Dynamic require npm/@typescript-eslint/[email protected] 🚫
Dynamic require npm/@typescript-eslint/[email protected] 🚫
Dynamic require npm/@typescript-eslint/[email protected] 🚫
Floating dependency npm/@types/[email protected] 🚫
Floating dependency npm/@types/[email protected] 🚫
Floating dependency npm/@types/[email protected] 🚫
Floating dependency npm/@types/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Shell access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Dynamic require npm/[email protected] 🚫

View full report↗︎

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What are unmaintained packages?

Package has not been updated in more than 5 years and may be unmaintained. Problems with the package may go unaddressed.

Package should publish periodic maintenance releases if they are maintained, or deprecate if they have no intention in further maintenance.

What are trivial packages?

Packages less than 10 lines of code are easily copied into your own project and may not warrant the additional supply chain risk of an external dependency.

Removing this package as a dependency and implementing its logic will reduce supply chain risk.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is dynamic require?

Dynamic require can indicate the package is performing dangerous or unsafe dynamic code execution.

Packages should avoid dynamic imports when possible. Audit the use of dynamic require to ensure it is not executing malicious or vulnerable code.

What are wildcard dependencies?

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Packages should specify properly semver ranges to avoid version conflicts.

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@guibranco guibranco enabled auto-merge (squash) August 16, 2024 17:56
@gstraccini gstraccini bot added the ☑️ auto-merge Auto-merge enabled by gstraccini-bot label Aug 16, 2024
Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Aug 16, 2024
@guibranco
Copy link
Member

@depfu merge

Copy link

Infisical secrets check: ✅ No secrets leaked!

Scan results:

5:56PM INF scanning for exposed secrets...
5:56PM INF 231 commits scanned.
5:56PM INF scan completed in 911ms
5:56PM INF no leaks found

Copy link

sonarcloud bot commented Aug 16, 2024

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d4d447f and e49098a.

Files ignored due to path filters (1)
  • POCUploadStream/ClientApp/package-lock.json is excluded by !**/package-lock.json
Files selected for processing (1)
  • POCUploadStream/ClientApp/package.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • POCUploadStream/ClientApp/package.json

@guibranco guibranco merged commit 71e7e8c into main Aug 16, 2024
16 of 17 checks passed
@guibranco guibranco deleted the depfu/update/POCUploadStreamClientApp/npm/react-router-dom-6.26.1 branch August 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Auto-merge enabled by gstraccini-bot 🤖 bot Issue/Pull request created by bot depfu korbit-code-analysis size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant