Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php] Update phpunit/phpunit 11.3.6 → 11.4.0 (minor) #117

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Oct 6, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ phpunit/phpunit (11.3.6 → 11.4.0) · Repo

Release Notes

11.4.0

Changed

  • #5915: Bootstrap extensions before building test suite
  • #5917: Seal event facade before loading the test suite
  • #5923: Filter configured deprecation triggers when displaying deprecation details
  • #5927: #[RequiresPhpunitExtension] attribute
  • #5928: Filter tests based on the PHP extensions they require
  • #5964: Better error message when data provider is invalid
  • The XML configuration file generator now references vendor/phpunit/phpunit/phpunit.xsd (instead of https://schema.phpunit.de/X.Y/phpunit.xsd) when PHPUnit was installed using Composer and phpunit --generate-configuration was invoked in the directory where vendor is located
  • The --migrate-configuration command no longer replaces vendor/phpunit/phpunit/phpunit.xsd with https://schema.phpunit.de/X.Y/phpunit.xsd
  • The output of --list-groups now shows how many tests a group contains
  • The output of --list-suites now shows how many tests a test suite contains

Deprecated

  • #5951: includeUncoveredFiles configuration option
  • #5958: Support for #[CoversTrait] and #[UsesTrait] attributes
  • #5960: Support for targeting trait methods with the #[CoversMethod] and #[UsesMethod] attributes (and respective annotations)

How to install or update PHPUnit

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 63 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Summary by Sourcery

Update PHPUnit to version 11.4.0 to incorporate the latest changes and improvements.

Build:

  • Update phpunit/phpunit dependency from version 11.3.6 to 11.4.0 in composer.json.

@depfu depfu bot added the depfu label Oct 6, 2024
Copy link

korbit-ai bot commented Oct 6, 2024

By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the /korbit-review command in a comment.

Copy link

semanticdiff-com bot commented Oct 6, 2024

Review changes with SemanticDiff.

Analyzed 1 of 2 files.

Filename Status
✔️ composer.json Analyzed
composer.lock Unsupported file format

Copy link

pr-code-reviewer bot commented Oct 6, 2024

👋 Hi there!

Everything looks good!


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

Copy link

senior-dev-bot bot commented Oct 6, 2024

Hi there! 👋 Thanks for opening a PR. It looks like you've already reached the 5 review limit on our Basic Plan for the week. If you still want a review, feel free to upgrade your subscription in the Web App and then reopen the PR

Copy link

sourcery-ai bot commented Oct 6, 2024

Reviewer's Guide by Sourcery

This pull request updates the PHPUnit dependency from version 11.3.6 to 11.4.0. The update includes several changes and improvements to PHPUnit's functionality, with a focus on enhancing test suite management and improving error reporting.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update PHPUnit dependency to version 11.4.0
  • Changed composer.json to require phpunit/phpunit ^11.4.0 instead of ^11.3.6
  • Introduced changes to bootstrap process and event handling
  • Added new attribute #[RequiresPhpunitExtension] for extension requirements
  • Improved filtering for tests based on required PHP extensions
  • Enhanced error messages for invalid data providers
  • Modified XML configuration file generation and migration
  • Updated output for --list-groups and --list-suites commands to show test counts
  • Deprecated includeUncoveredFiles configuration option
  • Deprecated support for #[CoversTrait] and #[UsesTrait] attributes
  • Deprecated support for targeting trait methods with #[CoversMethod] and #[UsesMethod] attributes
composer.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Oct 6, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Potential issues, bugs, and flaws that can introduce unwanted behavior.

  1. Package versioning:

    • composer.json updates the phpunit/phpunit package version from ^11.3.6 to ^11.4.0. This change could introduce breaking changes if the new version contains modifications that are incompatible with the existing codebase. It’s advisable to review the release notes for PHPUnit 11.4.0 for any breaking changes or deprecations.
  2. Manual content hash in composer.lock:

    • The content-hash in the composer.lock has changed, which is expected after dependency updates. However, manually making tweaks to this file without running composer update can lead to inconsistency between the composer.json and composer.lock. Ensure that both files are synchronized properly using composer commands to avoid unexpected behavior.
  3. Potential source URL mismatch:

    • The reference URL for PHPUnit has changed appropriately according to the version update, but if any upstream repository has been modified or the referenced commit is not properly tagged, that could lead to consistency issues during deployment. Make sure dependencies are sourced from stable tags rather than branches unless intentional.

Code suggestions and improvements for better exception handling, logic, standardization, and consistency (without impeding code quality).

  1. Update dependency management process (composer.json, composer.lock):

    • Always use Composer commands like composer require or composer update to manage dependencies. This practice helps in maintaining composer.lock in lockstep with composer.json, thus avoiding discrepancies and ensuring version integrity.
  2. Documentation of package updates:

    • It may be beneficial to add documentation (like a CHANGELOG.md file or comment in the commit) detailing what changes or tests should be performed in the application after upgrading crucial packages like PHPUnit. This applies to paths like composer.json and composer.lock and ensures that the rest of the development team is aware of the new requirements after an upgrade.
  3. Version testing:

    • Implement automated integration tests that target major dependency updates, such as PHPUnit changes. This can help to validate the updates in a controlled environment before deploying into production. You can document these tests in your project documentation to maintain transparency across development workflows.

Copy link

instapr bot commented Oct 6, 2024

### Feedback:

- Version updated to `phpunit/phpunit` 11.4.0 ✓
- Review and test results completed.

@github-actions github-actions bot added the size/S label Oct 6, 2024
Copy link

deepsource-io bot commented Oct 6, 2024

Here's the code health analysis summary for commits c744ae7..92951c0. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource SQL LogoSQL✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource PHP LogoPHP✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePhp
Branch Coverage100%100%
Composite Coverage33.3%33.3%
Line Coverage33.3%33.3%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@guibranco guibranco enabled auto-merge (squash) October 6, 2024 10:46
@gstraccini gstraccini bot added the ☑️ auto-merge Auto-merge enabled by gstraccini-bot label Oct 6, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, depfu[bot]!). We assume it knows what it's doing!

Copy link
Member

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@gstraccini gstraccini bot added the 🤖 bot Issue/Pull request created by bot label Oct 6, 2024
@guibranco
Copy link
Member

@depfu merge

Copy link

github-actions bot commented Oct 6, 2024

Infisical secrets check: ✅ No secrets leaked!
Scan results:

10:46AM INF scanning for exposed secrets...
10:46AM INF 113 commits scanned.
10:46AM INF scan completed in 345ms
10:46AM INF no leaks found

Copy link

sonarcloud bot commented Oct 6, 2024

@guibranco guibranco merged commit 761ea6b into main Oct 6, 2024
22 checks passed
@guibranco guibranco deleted the depfu/update/composer/phpunit/phpunit-11.4.0 branch October 6, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☑️ auto-merge Auto-merge enabled by gstraccini-bot 🤖 bot Issue/Pull request created by bot depfu size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant