Fixed tester/contributor cloaks (and some aura fixes) #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added EdwinMindcraft and The_Icy_One to the list
|
Can confirm I am awesome, although that lookup problem is because I wasn't being awesome and just copy/pasted the old code from before UUIDs were prevalent, and bodged till it worked. |
|
Whelp just realized the aura particle render system had never been ported from 1.7.10. @EdwinMindcraft do you happen to know what needs to be done to get that working? |
Networked auras are still broken
jjtParadox
changed the title
|
Auras should be working clientside now, but data is not synced across servers. That'll have to wait until the PR mentioned in the primary post is merged in. |
jjtParadox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloaks and auras broke when Mithion's website moved to HTTPS. The aura code was also erroneously using username instead of UUID to do lookups.
Also added EdwinMindcraft and The_Icy_One to the list, cause those two are pretty awesome.
Also the cloak rendering is clipping through players' arms when they move. Haven't yet figured out how to fix that.
UPDATE: Auras are working client side. Networking will be added after PR #391 is merged in.