Build Grim #1477
Build Grim #1477
Conversation
|
|
People on discord complained in regards of Grim not being up to date and
having to compile it on each push to the main branch; this was made to calm
people down and AoElite said it's fine to automatically release a jar to
GitHub (basically what this PR does)
…On Mon, May 20, 2024, 10:52 PM ManInMyVan ***@***.***> wrote:
1. Why would we release every build?
2. We already do this (minus releases)
https://github.com/GrimAnticheat/Grim/blob/2.0/.github/workflows/gradle-publish.yml
—
Reply to this email directly, view it on GitHub
<#1477 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AICPHKUCFVHXF7VWQJKF3ATZDJIBBAVCNFSM6AAAAABIAENFL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRRGEYDCNBWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@Anthony01M |
used for tag_name in Release to Github This basically gets the last commit and just puts it as a tag btw forgot to explain |
|
Why not modify the existing workflow? |
forgot to remove body_path which adds the changelogs text file; was removed as there was some errors with change logs generating
didn't notice it does almost what I do, but anyways, for some reason the change logs just errors out, so commented that until I find a fix myself later on, this works now without change logs being recorded unfortunately. |
| draft: false | ||
| prerelease: false |
There was a problem hiding this comment.
I'd mark these releases as pre-releases or drafts. It'll get confusing over time.
|
This is the main branch tho, so it should be release, not draft or
prerelease.
LMK if you have another opinion.
…On Mon, May 27, 2024, 6:38 PM Jones ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/gradle-publish.yml
<#1477 (comment)>:
> + draft: false
+ prerelease: false
I'd mark these releases as pre-releases or drafts. It'll get confusing
over time.
—
Reply to this email directly, view it on GitHub
<#1477 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AICPHKXHTULU7ALSHBGFBMTZENHONAVCNFSM6AAAAABIAENFL2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBRGE3DSNBTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's true. I thought that since these releases aren't any "official" releases (e.g., ones that are uploaded to plugin websites like Hangar or SpigotMC), they shouldn't be marked as releases but rather pre-releases. |
|
hmm let's wait and see what AoElite thinks about this.
…On Mon, May 27, 2024, 7:06 PM Jones ***@***.***> wrote:
This is the main branch tho, so it should be release, not draft or
prerelease. LMK if you have another opinion.
That's true. I thought that since these releases aren't any "official"
releases (e.g., ones that are uploaded to plugin websites like Hangar or
SpigotMC), they shouldn't be marked as releases but rather pre-releases.
—
Reply to this email directly, view it on GitHub
<#1477 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AICPHKSKEUY75RWUHDBNQNLZENKXDAVCNFSM6AAAAABIAENFL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZTG43TKNJVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This PR allows GrimAC to automatically build itself and gets released to Github Releases.
preview: