Qodana Scan

feat: Key-combinations to improve usability. CTRL + W closes the curr… #40

Triggered via push July 30, 2023 12:15

Griefed

pushed 992cc9f

ms5

Status Success

Total duration 8m 8s

Artifacts –

This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

qodana.yml

on: push

qodana

7m 57s

Annotations

58 warnings and 39 notices

Constructor parameter is never used as a property: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L52

Constructor parameter is never used as a property

Unresolved reference in KDoc: serverpackcreator-api/src/commonMain/kotlin/de/griefed/serverpackcreator/api/ServerPack.kt#L378

Cannot resolve symbol 'combination'

Unresolved reference in KDoc: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/plugins/ServerPackCreatorPlugin.kt#L46

Cannot resolve symbol 'wrapper'

Constant conditions: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/ConfigEditor.kt#L741

Condition 'properties.toString() != Gui.createserverpack_gui_quickselect_choose.toString()' is always true when reached

Constant conditions: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/ConfigEditor.kt#L727

Condition 'icon.toString() != Gui.createserverpack_gui_quickselect_choose.toString()' is always true when reached

Constant conditions: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/MainPanel.kt#L94

Condition 'config.editorTitle.title != Gui.createserverpack_gui_title_new.toString()' is always true when reached

Constant conditions: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/ConfigEditor.kt#L1529

Condition 'editorTitle.title == Gui.createserverpack_gui_title_new.toString()' is always false

Unused import directive: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ConfigurationHandler.kt#L22

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/ConfigToHasteBinItem.kt#L30

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/ConfigToHasteBinItem.kt#L31

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/about/MigrationInfoItem.kt#L35

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/ScrollTextArea.kt#L31

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/about/MigrationInfoItem.kt#L36

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/about/MigrationInfoItem.kt#L34

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/MainMenuBar.kt#L34

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/ConfigToHasteBinItem.kt#L33

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/MainMenuBar.kt#L32

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/LoadConfigItem.kt#L24

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/about/ThirdPartyNoticesItem.kt#L23

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/SaveAllConfigsItem.kt#L23

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/ConfigToHasteBinItem.kt#L27

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/ScrollTextArea.kt#L32

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/ElementLabel.kt#L23

Unused import directive

Unused import directive: serverpackcreator-plugin-example/src/main/kotlin/de/griefed/example/kotlin/Example.kt#L29

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/file/ConfigToHasteBinItem.kt#L32

Unused import directive

Unused import directive: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/ScrollTextArea.kt#L34

Unused import directive

String template as argument to logging call: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ServerPackHandler.kt#L357

String template as argument to `debug()` logging call

String template as argument to logging call: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ServerPackHandler.kt#L367

String template as argument to `debug()` logging call

String template as argument to logging call: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ServerPackHandler.kt#L914

String template as argument to `debug()` logging call

String template as argument to logging call: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ServerPackHandler.kt#L913

String template as argument to `debug()` logging call

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L320

Redundant character escape `\\+` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L322

Redundant character escape `\\/` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L320

Redundant character escape `\\/` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L320

Redundant character escape `\\.` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L322

Redundant character escape `\\+` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/utilities/common/FileUtilities.kt#L115

Redundant character escape `\\}` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L298

Redundant character escape `\\.` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L298

Redundant character escape `\\/` in RegExp

Redundant character escape: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L322

Redundant character escape `\\.` in RegExp

Single character alternation: serverpackcreator-api/src/jvmMain/kotlin/mslinks/ShellLinkHelper.kt#L36

Single character alternation in RegExp

Existing backing field without assignment: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ApiProperties.kt#L723

Existing backing field is not assigned by the setter

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L49

Property "updateDialogs" is never used

Unused symbol: serverpackcreator-api/src/commonMain/kotlin/de/griefed/serverpackcreator/api/utilities/common/ListUtilities.kt#L232

Function "parallelMap" is never used

Unused symbol: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/versionmeta/minecraft/MinecraftMeta.kt#L585

Function "settingsDependantVersionsArrayAscending" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/SuggestionProvider.kt#L53

Property "apiProperties" is never used

Unused symbol: serverpackcreator-updater/src/main/kotlin/de/griefed/versionchecker/GitLabChecker.kt#L59

Constructor is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/settings/SettingsEditorTab.kt#L29

Property "guiProps" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L48

Property "updateChecker" is never used

Unused symbol: serverpackcreator-updater/src/main/kotlin/de/griefed/versionchecker/GitLabChecker.kt#L45

Class "GitLabChecker" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/utilities/ImageUtilities.kt#L41

Function "imageFromResourceStream" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L47

Property "apiWrapper" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/utilities/ImageUtilities.kt#L52

Function "imageIconFromResourceStream" is never used

Unused symbol: serverpackcreator-updater/src/main/kotlin/de/griefed/versionchecker/GitHubChecker.kt#L72

Constructor is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L46

Property "guiProps" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L51

Property "frame" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L50

Property "migrationManager" is never used

Unused symbol: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/KeyComboManager.kt#L53

Property "menu" is never used

Unused symbol: serverpackcreator-updater/src/main/kotlin/de/griefed/versionchecker/GitLabChecker.kt#L71

Constructor is never used

Boolean literal argument without parameter name: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/about/MigrationInfoItem.kt#L131

Boolean literal argument without a parameter name

Boolean literal argument without parameter name: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/menu/about/MigrationInfoItem.kt#L131

Boolean literal argument without a parameter name

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/Tracker.kt#L87

Const property name `size` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemIDFS.kt#L221

Const property name `HIDDEN_ID_recycle2` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/VistaIDList.kt#L70

Const property name `signature` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/ConsoleData.kt#L299

Const property name `signature` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/ConsoleFEData.kt#L55

Const property name `signature` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/EnvironmentVariable.kt#L70

Const property name `signature` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/ConsoleData.kt#L300

Const property name `size` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/ConsoleFEData.kt#L56

Const property name `size` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/ShellLinkHelper.kt#L244

Const property name `backSlash` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/EnvironmentVariable.kt#L71

Const property name `size` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/ShellLinkHelper.kt#L245

Const property name `backSlashBackSlash` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/extra/Tracker.kt#L86

Const property name `signature` should not contain lowercase letters

Const property naming convention: serverpackcreator-api/src/jvmMain/kotlin/mslinks/ShellLinkHeader.kt#L114

Const property name `headerSize` should not contain lowercase letters

Join declaration and assignment: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/LoggingConfig.kt#L208

Can be joined with assignment

Leaking 'this' in constructor: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/ScrollTextField.kt#L82

Leaking 'this' in constructor of non-final class ScrollTextField

Leaking 'this' in constructor: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/ScrollTextField.kt#L81

Leaking 'this' in constructor of non-final class ScrollTextField

Leaking 'this' in constructor: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/StatusIcon.kt#L41

Leaking 'this' in constructor of non-final class StatusIcon

Leaking 'this' in constructor: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/logs/LogTailer.kt#L48

Leaking 'this' in constructor of non-final class LogTailer

Leaking 'this' in constructor: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/components/BalloonTipButton.kt#L50

Leaking 'this' in constructor of non-final class BalloonTipButton

Might be 'const': serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/utilities/common/ClassUtilities.kt#L31

Might be 'const'

Might be 'const': serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/utilities/common/ClassUtilities.kt#L30

Might be 'const'

Class member can have 'private' visibility: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/GuiProps.kt#L221

Property 'settingsIcon' could be private

Class member can have 'private' visibility: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/MainPanel.kt#L57

Property 'tabbedLogsTab' could be private

Class member can have 'private' visibility: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ApiProperties.kt#L462

Property 'trueFalseRegex' could be private

Class member can have 'private' visibility: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemIDFS.kt#L28

Property 'attributes' could be private

Class member can have 'private' visibility: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/GuiProps.kt#L228

Property 'helpIcon' could be private

Class member can have 'private' visibility: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ApiProperties.kt#L464

Property 'serverPacksRegex' could be private

Class member can have 'private' visibility: serverpackcreator-api/src/jvmMain/kotlin/mslinks/data/ItemID.kt#L222

Property 'TYPE_DRIVE_FIXED' could be private

Class member can have 'private' visibility: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/versionmeta/fabric/FabricInstaller.kt#L47

Property 'improvedLauncherUrlTemplate' could be private

Class member can have 'private' visibility: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/control/components/LarsonScanner.kt#L607

Function 'pause' could be private

Class member can have 'private' visibility: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/TabbedConfigsTab.kt#L137

Function 'loadConfig' could be private

Class member can have 'private' visibility: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/ApiProperties.kt#L463

Property 'alphaBetaRegex' could be private

Class member can have 'private' visibility: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/MainPanel.kt#L58

Property 'settingsEditorTab' could be private

Redundant 'constructor' keyword: serverpackcreator-app/src/main/kotlin/de/griefed/serverpackcreator/app/Mode.kt#L28

Redundant 'constructor' keyword

Redundant 'constructor' keyword: serverpackcreator-api/src/jvmMain/kotlin/de/griefed/serverpackcreator/api/versionmeta/VersionMeta.kt#L64

Redundant 'constructor' keyword

Redundant 'constructor' keyword: serverpackcreator-updater/src/main/kotlin/de/griefed/serverpackcreator/updater/MigrationManager.kt#L66

Redundant 'constructor' keyword

Range can be converted to indices or iteration: serverpackcreator-gui/src/main/kotlin/de/griefed/serverpackcreator/gui/window/configs/components/TextIcon.kt#L179

Range could be replaced with '.indices' call

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Key-combinations to improve usability. CTRL + W closes the curr… #40

Summary