-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add devcontainer setup #1725
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of suggestions to use uv
:
&& export DEBIAN_FRONTEND=noninteractive && apt-get install -y libboost-dev \ | ||
&& apt-get clean && rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/* && rm -rf /tmp/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add some basic python tooling like pipx
& uv
? For example:
&& export DEBIAN_FRONTEND=noninteractive && apt-get install -y libboost-dev \ | |
&& apt-get clean && rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/* && rm -rf /tmp/* | |
&& export DEBIAN_FRONTEND=noninteractive && apt-get install -y libboost-dev \ | |
&& apt-get install pipx && ensurepath && pipx install uv \ | |
&& apt-get clean && rm -rf /var/cache/apt/* && rm -rf /var/lib/apt/lists/* && rm -rf /tmp/* |
(the pipx
installation assumes the base image is a reasonably recent Ubuntu version: https://pipx.pypa.io/latest/installation/#on-linux)
python -m venv .venv | ||
source .venv/bin/activate | ||
pip install --upgrade pip setuptools wheel | ||
pip install -e . | ||
pip install -r requirements-dev.txt | ||
pip install -i https://test.pypi.org/simple/ atlas4py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we install uv
in the dockerfile then we can use it here which should be nicer and much faster:
python -m venv .venv | |
source .venv/bin/activate | |
pip install --upgrade pip setuptools wheel | |
pip install -e . | |
pip install -r requirements-dev.txt | |
pip install -i https://test.pypi.org/simple/ atlas4py | |
uv venv .venv | |
source .venv/bin/activate | |
uv pip install -r requirements-dev.txt | |
uv pip install -e . | |
uv pip install -i https://test.pypi.org/simple/ atlas4py |
Should we just |
Yes, I agree. I don't think we need a venv inside the container |
No description provided.