Change bloom layer to use mixin instead of enumHelper #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
added
the
type: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As the title says.
Implementation Details
Adds two mixins targeting
BlockRenderLayer.class,BlockRenderPass.classandChunkRenderPass.class, adding the bloom layer during initialization.Outcome
This fixes issues with EnumMaps, like embeddedt/VintageFix#112 .↑ it doesn't, after I cleaned up the workplace and run client again, weird. But ig this PR is still fine as a refactor.
Additional Information
I've also tried to get Nothirium patch using mixin, but I'm still waiting for auther's reply since it's gonna use some codes from Nothirium but it's ARR licenced.The Nothirium compat now uses mixin as well. Thanks to @Meldexun for allowing me to use some of Nothirium code here!
For Vintagium I failed to get mixin work and idk why 😢.↑ nvm I figured it out.
Potential Compatibility Issues
None that I can think of?