Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModularUI setup #2264

Merged
merged 20 commits into from
Dec 8, 2023
Merged

ModularUI setup #2264

merged 20 commits into from
Dec 8, 2023

Conversation

serenibyss
Copy link
Member

@serenibyss serenibyss commented Dec 7, 2023

Adds MUI, deprecates old UI, sets up an easy way for UIs to port to MUI and creates the standard 4 themes (standard, bronze, steel, primitive).

Also ports 3 UIs as proof of concept:

Crate (MTE example):

Before:
69B3561A-2A30-4DF3-A525-6CB6A8FE4BD4

After:
78B755AA-2244-405A-A454-0DAA58BAB3C8

Storage Cover (Cover example):

Before:
BF0523E3-7ED7-4C9A-8508-DA9D31EFF959

After (the selected slot is not properly getting theme applied, but there is a todo comment marking it):
803814BC-6DBF-488F-963E-F2587180B9D0

Programmed Circuit (Item with UI example):

Before:
D4967073-E4D7-4D91-AFDC-4CB260DA761F_4_5005_c

After (the selected slot background not being themed has now been fixed):
C378846A-B426-477B-A093-AD6863DEBCBC

@serenibyss serenibyss added the type: refactor Suggestion to refactor a section of code label Dec 7, 2023
Copy link
Contributor

@ALongStringOfNumbers ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When holding a stack of integrated circuits, setting the config number through the MUI window and then closing the window will void all the circuits except for 1. This does not happen on master.

When opening a MUI GUI with debug mode enabled, there is a small green dot that follows the cursor. I am not sure if this is intended or not, and only happens when debug mode is on. It seems like something on MUI's side, which is why I am not sure if it is intended or not.

@serenibyss serenibyss marked this pull request as ready for review December 8, 2023 02:27
@serenibyss serenibyss requested review from a team as code owners December 8, 2023 02:27
@serenibyss serenibyss merged commit 909aa5b into master Dec 8, 2023
4 checks passed
@serenibyss serenibyss deleted the sb-mui-base branch December 8, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Suggestion to refactor a section of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants