Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Laser Pipe Client Desync + Small Rework #2245

Merged
merged 2 commits into from
Dec 3, 2023

Conversation

ghzdude
Copy link
Contributor

@ghzdude ghzdude commented Dec 3, 2023

What

fixes laser pipe not syncing isActive to client on world load
small rework to setActive() to make it simpler

Implementation Details

made setActive() simpler
moved the lambda in schedualTask() to its own method reference
add initial sync methods and call schedualTask() on sending data

Outcome

laser renders at the correct times,

Potential Compatibility Issues

none

schedule disconnect asap on world load
simplify `setActive()`
@ghzdude ghzdude added the type: bug Something isn't working label Dec 3, 2023
@ghzdude ghzdude requested a review from a team as a code owner December 3, 2023 06:45
@ALongStringOfNumbers ALongStringOfNumbers added this to the 2.8.2 milestone Dec 3, 2023
@htmlcsjs htmlcsjs self-assigned this Dec 3, 2023
Copy link
Member

@htmlcsjs htmlcsjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this for me, code looks good and works fine in game

@htmlcsjs htmlcsjs merged commit a0fa877 into GregTechCEu:master Dec 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants