Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time sync aggregation parameters resolution #945

Merged
merged 7 commits into from
Aug 8, 2024
Merged

Time sync aggregation parameters resolution #945

merged 7 commits into from
Aug 8, 2024

Conversation

narekhovhannisyan
Copy link
Member

@narekhovhannisyan narekhovhannisyan commented Aug 8, 2024 •
edited
Loading

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • If the parameter doesn't have aggregation method, then omit it from the results.

@narekhovhannisyan narekhovhannisyan self-assigned this Aug 8, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Aug 8, 2024 that may be closed by this pull request
Refine time-sync config logic #939
Closed
3 tasks
@narekhovhannisyan narekhovhannisyan changed the title Time sync aggregation Time sync aggregation parameters resolution Aug 8, 2024
jmcook1186
jmcook1186 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@narekhovhannisyan narekhovhannisyan merged commit f6b58b7 into main Aug 8, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the time-sync-aggregation branch August 8, 2024 16:26
This was referenced Aug 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refine time-sync config logic
3 participants
@narekhovhannisyan @manushak @jmcook1186