Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove params.ts file and override-params section from the manifest #908

Merged
merged 17 commits into from
Jul 16, 2024
Merged

Remove params.ts file and override-params section from the manifest #908

merged 17 commits into from
Jul 16, 2024

Conversation

manushak
Copy link
Contributor

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • remove override-params and params.ts
  • change the aggregation section in the manifest to be like
aggregation:
  metrics:
    "cpu/utilization":
      method: avg
    "cpu/energy":
      method: sum
  type: "both"

@manushak
fix(util): remove params and update aggregation in the manifest s…
e66b168 
…chema
@manushak
fix(src): remove all files realted to params
2cc4398
@manushak
fix(src): remove override-params from config and from IfRunArgs i…
c17a8f2 
…nterface
@manushak
fix(src): remove redundant types and strings
793ee6d
@manushak
fix(util): remove override-params from the args.ts
99e4336
@manushak
feat(types): update aggregation types
25be491
@manushak
feat(util): update metrics type
9e484b2
@manushak
feat(src): add temp workaround to solve issue related to timeSync
1aca293
@manushak
feat(src): update load function to not deal with params
061df46
@manushak
fix(util): remove SYNCING_PARAMETERS from debugger log
c0556cc
@manushak
feat(src): update getAggregationMethod function call
a4a9fc5
@manushak
test(src): update tests according to changes
84cfc8f
@manushak
fix(config): remove message
a83cc42
@manushak
fix(lib): fix aggregation method check
608bd8e
@manushak
docs(src): update documentations
ff60513
@manushak
test(mocks): update mocks
4a5e15d
@manushak
fix(manifests): update aggregation section in the manifests
6dd3984
@manushak manushak added this to the Inputs and Outputs milestone Jul 11, 2024
@manushak manushak self-assigned this Jul 11, 2024
@manushak manushak changed the title Remove params.ts and override-params section from the manifest Remove params.ts file and override-params section from the manifest Jul 11, 2024
jmcook1186
jmcook1186 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@narekhovhannisyan narekhovhannisyan merged commit 55276c9 into main Jul 16, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the remove-override-params branch July 16, 2024 16:45
This was linked to issues Jul 17, 2024
Move aggregation: method definition to feature config #842
Closed
Remove params.ts and related logic from IF #814
Closed
This was referenced Aug 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@manushak manushak

Labels
None yet
Projects
IF
Status: Done
Milestone
Inputs and Outputs
Development

Successfully merging this pull request may close these issues.

Move aggregation: method definition to feature config Remove params.ts and related logic from IF
3 participants
@manushak @narekhovhannisyan @jmcook1186