Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build if-csv #891

Merged
merged 20 commits into from
Jul 16, 2024
Merged

Build if-csv #891

merged 20 commits into from
Jul 16, 2024

Conversation

manushak
Copy link
Contributor

@manushak manushak commented Jul 8, 2024 •
edited
Loading

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • add if-csv command line tool
  • there are 3 cases to test:
    • with output npm run if-csv -- -m ./manifests/outputs/plugins/csv-lookup/cloud-metadata/success.yaml --params cpu-cores-utilized -o ./manifests/outputs/csv-lookup
    • without output npm run if-csv -- -m ./manifests/outputs/plugins/csv-lookup/cloud-metadata/success.yaml --params cpu-cores-utilized
    • withe pipe npm run if-run -- -m ./manifests/examples/builtins/csv-lookup/cloud-metadata/success.yml | npm run if-csv -- --params cpu-cores-utilized

@manushak manushak self-assigned this Jul 8, 2024
@manushak manushak changed the title Build If-csv Build if-csv Jul 8, 2024
@manushak manushak linked an issue Jul 8, 2024 that may be closed by this pull request
Create if-csv script #784
Closed
7 tasks
@manushak manushak marked this pull request as draft July 9, 2024 15:03
@manushak manushak marked this pull request as ready for review July 10, 2024 09:45
narekhovhannisyan
narekhovhannisyan reviewed Jul 16, 2024
View reviewed changes
src/if-csv/util/args.ts

if (!params) {
throw new ParseCliParamsError(PARAMS_NOT_PRESENT);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant params check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this params is the if-csv specific flag

narekhovhannisyan
narekhovhannisyan requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@narekhovhannisyan narekhovhannisyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check comments above

@narekhovhannisyan narekhovhannisyan merged commit 3ea46b3 into main Jul 16, 2024
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the if-csv branch July 16, 2024 16:44
This was referenced Aug 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@narekhovhannisyan narekhovhannisyan narekhovhannisyan approved these changes

Assignees

@manushak manushak

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create if-csv script
3 participants
@manushak @narekhovhannisyan @jmcook1186