Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new args support, introduced yaml save. #108

Merged
merged 7 commits into from
Aug 31, 2023
Merged

Added new args support, introduced yaml save. #108

merged 7 commits into from
Aug 31, 2023

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Added support for saving object as a YAML file.
  • Added support for command line arguments such as --impl and --ompl.

@narekhovhannisyan narekhovhannisyan self-assigned this Aug 30, 2023
jawache
jawache approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jawache jawache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@narekhovhannisyan narekhovhannisyan merged commit 2885628 into dev Aug 31, 2023
2 checks passed
@narekhovhannisyan narekhovhannisyan deleted the save-object-yml branch August 31, 2023 05:28
@narekhovhannisyan
Copy link
Member Author

#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jawache jawache jawache approved these changes

@gnanakeethan gnanakeethan Awaiting requested review from gnanakeethan

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narekhovhannisyan @jawache