Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time sync fix #1003

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Time sync fix #1003

merged 3 commits into from
Sep 9, 2024

Conversation

narekhovhannisyan
Copy link
Member

Types of changes

  • Enhancement (project structure, spelling, grammar, formatting)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

A description of the changes proposed in the Pull Request

  • Fixed aggregation default method.
  • Removed additional one second.

@narekhovhannisyan narekhovhannisyan self-assigned this Sep 4, 2024
@narekhovhannisyan narekhovhannisyan linked an issue Sep 4, 2024 that may be closed by this pull request
Time Sync issues: null values for energy-cpu and extra timestamp #999
Closed
jmcook1186
jmcook1186 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jmcook1186 jmcook1186 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm!

@manushak manushak merged commit 490f283 into main Sep 9, 2024
2 checks passed
@manushak manushak deleted the time-sync-fix branch September 9, 2024 06:49
@narekhovhannisyan narekhovhannisyan mentioned this pull request Sep 23, 2024
Closed
6 tasks
This was referenced Oct 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcook1186 jmcook1186 jmcook1186 approved these changes

@manushak manushak manushak approved these changes

Assignees

@narekhovhannisyan narekhovhannisyan

Labels
None yet
Projects
IF
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time Sync issues: null values for energy-cpu and extra timestamp
3 participants
@narekhovhannisyan @manushak @jmcook1186