Skip to content

Commit

Permalink
Merge pull request #942 from Green-Software-Foundation/emit-warning
Browse files Browse the repository at this point in the history
Emit warning
  • Loading branch information
narekhovhannisyan committed Aug 8, 2024
2 parents f6b58b7 + 7f7f717 commit ce87cca
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/if-run/config/strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ Note that for the '--output' option you also need to define the output type in y
PREPARING_OUTPUT_DATA: 'Preparing output data',
EXPORTING_TO_YAML_FILE: (savepath: string) =>
`Exporting to yaml file: ${savepath}`,
EMPTY_PIPELINE: `You're using an old style manifest. Please update for phased execution. More information can be found here:
https://if.greensoftware.foundation/major-concepts/manifest-file`,
/** Exhaust messages */
OUTPUT_REQUIRED:
'Output path is required, please make sure output is configured properly.',
Expand Down
13 changes: 12 additions & 1 deletion src/if-run/lib/compute.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,14 @@ import {addExplainData} from './explain';

import {mergeObjects} from '../util/helpers';
import {debugLogger} from '../../common/util/debug-logger';
import {logger} from '../../common/util/logger';

import {STRINGS} from '../config/strings';

import {ComputeParams, Node, PhasedPipeline} from '../types/compute';
import {isExecute} from '../types/interface';

const {MERGING_DEFAULTS_WITH_INPUT_DATA} = STRINGS;
const {MERGING_DEFAULTS_WITH_INPUT_DATA, EMPTY_PIPELINE} = STRINGS;

/**
* Traverses all child nodes based on children grouping.
Expand Down Expand Up @@ -77,6 +78,16 @@ const computeNode = async (node: Node, params: ComputeParams): Promise<any> => {
inputStorage = mergeDefaults(inputStorage, defaults);
const pipelineCopy = structuredClone(pipeline) || {};

/** Checks if pipeline is not an array or empty object. */
if (
Array.isArray(pipelineCopy) ||
(typeof pipelineCopy === 'object' &&
pipelineCopy !== null &&
Object.keys(pipelineCopy).length === 0)
) {
logger.warn(EMPTY_PIPELINE);
}

/**
* If iteration is on observe pipeline, then executes observe plugins and sets the inputs value.
*/
Expand Down

0 comments on commit ce87cca

Please sign in to comment.