fix(lib): check if the globalConfig is undefined before get its prope…

…rty in e-mem and e-net
Green-Software-Foundation · Mar 28, 2024 · e66cda5 · e66cda5
1 parent 5349545
commit e66cda5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/lib/e-mem/index.ts b/src/lib/e-mem/index.ts
@@ -51,7 +51,8 @@ export const EMem = (globalConfig: ConfigParams): PluginInterface => {
     });
 
     //Manually add default value from CCF: https://www.cloudcarbonfootprint.org/docs/methodology/#memory
-    const energyPerGB = globalConfig['energy-per-gb'] ?? 0.000392;
+    const energyPerGB =
+      (globalConfig && globalConfig['energy-per-gb']) ?? 0.000392;
 
     return validate<z.infer<typeof schema>>(schema, {
       ...globalConfig,

diff --git a/src/lib/e-net/index.ts b/src/lib/e-net/index.ts
@@ -38,12 +38,18 @@ export const ENet = (globalConfig: ConfigParams): PluginInterface => {
       'energy-per-gb': z.number(),
     });
 
-    // Manually add default value
-    if (!globalConfig['energy-per-gb'] || globalConfig['energy-per-gb'] === 0) {
-      globalConfig['energy-per-gb'] = 0.001;
-    }
+    // Manually add default value from CCF: https://www.cloudcarbonfootprint.org/docs/methodology/#chosen-coefficient
+    const energyPerGB =
+      !globalConfig ||
+      !globalConfig['energy-per-gb'] ||
+      globalConfig['energy-per-gb'] === 0
+        ? 0.001
+        : globalConfig['energy-per-gb'];
 
-    return validate<z.infer<typeof schema>>(schema, globalConfig);
+    return validate<z.infer<typeof schema>>(schema, {
+      ...globalConfig,
+      'energy-per-gb': energyPerGB,
+    });
   };
 
   /**