Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration for disabling to cache JSON emission data #555

Merged

Conversation

YaSuenag
Copy link
Contributor

@YaSuenag YaSuenag commented Aug 24, 2024

Pull Request

Summary

Support dynamic update for emission data JSON file.

It is useful if we can update emission data when we use custom data via JSON datasource.
Currently JSON datasource would cache all of data in JSON on memory, so the update would not propagate even if it is updated. We have to restart WebAPI when we need to update emission data. It is not good for system operation.

I want to introduce CacheJsonData into JSON datasource configuration. If the user set it to false, JSON datasource would read emission data JSON file everytime when the request happens. This option is set to true by default, so this PR does not break current behavior.

Changes

  • JSON datasource
  • Test case for above
  • Document for JSON datasource

Checklist

  • Local Tests Passing?
  • CICD and Pipeline Tests Passing?
  • Added any new Tests?
  • Documentation Updates Made?
  • Are there any API Changes? If yes, please describe below.
  • This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No

Is this a breaking change?

No

Copy link
Collaborator

@danuw danuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danuw danuw merged commit e67716d into Green-Software-Foundation:dev Aug 27, 2024
9 checks passed
@danuw danuw added this to the Release 1.6 milestone Aug 27, 2024
@danuw danuw added the v1.6 label Aug 27, 2024
@YaSuenag YaSuenag deleted the pr/update-json-emissiondata branch August 27, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants