Upgrade to .NET 8.0

[tiwatsuka]

Pull Request

Issue Number: #401

Summary

Upgrade .NET version from 6.0 to 8.0.

Changes

• change value of <TargetFramework> in each .csproj file
• change base images of containers for development and building
• update .NET version contained in comments, documents, and settings

Checklist

• Local Tests Passing?
• CICD and Pipeline Tests Passing?
• Added any new Tests?
• Documentation Updates Made?
• Are there any API Changes? If yes, please describe below.
• This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No.

Is this a breaking change?

No.

This PR Closes #401

[bderusha]

These changes look reasonable. If the tests all pass

[codecov-commenter]

Codecov Report

Merging #404 (4ed21d4) into dev (b3b3189) will decrease coverage by 0.16%.
Report is 21 commits behind head on dev.
The diff coverage is 15.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #404      +/-   ##
==========================================
- Coverage   74.21%   74.06%   -0.16%     
==========================================
  Files          77       77              
  Lines        2637     2668      +31     
  Branches      266      268       +2     
==========================================
+ Hits         1957     1976      +19     
- Misses        598      611      +13     
+ Partials       82       81       -1     

Files	Coverage Δ
...re.WebApi/src/Controllers/CarbonAwareController.cs	93.82% <ø> (ø)
...arbonAware.WebApi/src/Models/CarbonIntensityDTO.cs	80.00% <100.00%> (-20.00%)	⬇️
src/CarbonAware.WebApi/src/Program.cs	80.26% <ø> (ø)
...s.ElectricityMaps/src/ElectricityMapsDataSource.cs	65.04% <50.00%> (+0.97%)	⬆️
...icityMapsFree/src/ElectricityMapsFreeDataSource.cs	0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

[Willmish]

@tiwatsuka highlighted https://techcommunity.microsoft.com/t5/apps-on-azure-blog/net-on-azure-functions-august-2023-roadmap-update/ba-p/3910098 :

• Current Sample Azure Functions uses In process model rather than Isolated worker model
  

[Sophietn]

This is blocked until we update Sample Azure Functions from In process model to Isolated worker model - this will be done in a new issue that @tiwatsuka will make

[Willmish]

To pass https://github.com/Green-Software-Foundation/carbon-aware-sdk/actions/runs/6879323122/job/18711361618?pr=404 , this requires a manual check, with proof of api-comparison passing (this is currently trying to compare to non-existing previous dotnet8 swagger definition)

[danuw]

As discussed moving to vnext

[YaSuenag]

Please update containerization.md because it mentions exporsed port number of WebAPI. It should be 8080.

https://learn.microsoft.com/en-us/dotnet/core/compatibility/containers/8.0/aspnet-port

[YaSuenag]

You've changed containerPort which cannot be modified via values.yaml, so we have to publish new chart. Could you bump up chart version like this?

98c4543

Note that CASDK maintainer should kick 5-publish-helm-chart.yaml publish after merging.

[YaSuenag]

I think 1.1.1 is a good version for this.

[YaSuenag]

I reconsidered that we have to release new chart after vNext because the chart includes application version (it is equivalent to the tag of container image).

So we can bump up chart version in another PR after vNext.

[YaSuenag]

LGTM

Thanks for your work!

[YaSuenag]

@vaughanknight @danuw I agree this PR.

[tiwatsuka]

@danuw I've just resolved documentation conflicts.
The workflows are not executed because they runs only for PR to main or dev. Could you execute them manually?

[YaSuenag]

I think we can add vnext/dotnet8-upgrade to .on.pull_request.branches in 1-pr.yaml in this branch temporally to run PR tests. Maybe it can run on draft PR, so you can move this to draft PR under PR testing, and move to PR again after removing this branch from 1-pr.yaml when all tests has been passed. Does it make sence?

[tiwatsuka]

All checks have passed except api-comparison.
https://github.com/Green-Software-Foundation/carbon-aware-sdk/actions/runs/8081752762

api-comparison cannot be checked this PR automatically as mentioned before.
#404 (comment)

[YaSuenag]

It's good news!

@vaughanknight @danuw Can you merge this to vnext/dotnet8-upgrade branch? #422 relies on this PR - it needs to be rebase after this PR.

[vaughanknight]

Looks good as discussed on the call, and all conflicts resolved. Thanks all!