-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4-release.yaml to publish container image for the release #342
Conversation
Signed-off-by: Yasumasa Suenaga <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dev #342 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 77 77
Lines 2637 2637
Branches 266 266
=======================================
Hits 1957 1957
Misses 598 598
Partials 82 82 |
Hi @YaSuenag , as discussed previously, I really believe this should be triggered by a merge into main, and take its version from a variable? I suppose I look at it the other way where we would automate creating the release page, when your suggestions imply that creating the release manually is the starting point. Speak tomorrow |
This workflow would be fired when GitHub release would be created. I assume each official release would be appeared in GitHub Release like https://github.com/Green-Software-Foundation/carbon-aware-sdk/releases/tag/v1.0.0 It doesn't matter if it is manual or not. I think this workflow should depend on release page. So we need to deploy other workflow(s) if we want to create new release automatically when we pushed some commits in
Ok, but I tested this PR on my forked repo as I wrote before: https://github.com/YaSuenag/carbon-aware-sdk/pkgs/container/carbon-aware-sdk/88739206?tag=v99.0.23 |
OK, let's discuss with the group tomorrow morning. Otherwise, happy to go with those changes and update in the future as needed. |
I will attend today's call, but I put down release workflow what I think in below:
I'm not sure when the release note should be created. Before 1 if it should be included in |
The workflow in above is ok? If so, I think we can merge this PR. |
Hi @YaSuenag , let's connect to merge this and check the first release. let me know |
Pull Request
#252
Summary
Add 4-release.yaml to ship container image of the release.
This workflow would be triggered when the maintainer creates new release on GitHub release page. The container image has both
latest
and release version tag. Container image is for both AMD64 and Arm64, and they are pushlished to GitHub Packages.You can see an example on my forked repo: https://github.com/YaSuenag/carbon-aware-sdk/pkgs/container/carbon-aware-sdk/88739206?tag=v99.0.23
Changes
Checklist
Are there API Changes?
No
Is this a breaking change?
No