Updates and Improvements to Unit Tests

[Kpopovs1]

Pull Request

Issue Number: #290

Summary

As a Carbon Aware application developer, I want to know that all the existing codepaths have been unit tested to ensure bugs are caught.

Changes

• Reviewed unit tests throughout the project and added new tests to improve code coverage.

Checklist

• Local Tests Passing?
• CICD and Pipeline Tests Passing?
• Added any new Tests?
• Documentation Updates Made?
• Are there any API Changes? If yes, please describe below.
• This is not a breaking change. If it is, please describe it below.

Are there API Changes?

No.

Is this a breaking change?

No.

Please follow
GitHub's suggested syntax
to link Pull Requests to Issues via keywords

This PR Closes #290

[codecov-commenter]

Codecov Report

Merging #298 (5edd0e7) into dev (159f99c) will increase coverage by 2.17%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev     #298      +/-   ##
==========================================
+ Coverage   79.55%   81.73%   +2.17%     
==========================================
  Files          69       69              
  Lines        2392     2392              
  Branches      244      244              
==========================================
+ Hits         1903     1955      +52     
+ Misses        408      355      -53     
- Partials       81       82       +1     

see 5 files with indirect coverage changes

[juzuluag]

This is looking good. Added a couple of comments and nits. Thanks for doing this @Kpopovs1 , @in4margaret and @JenMadiedo

[juzuluag]

More comments.

[juzuluag]

Few comments. Looking good 👍

[pritipath]

Thanks for improving the test coverage. Left a small nit comment, otherwise looks great

[juzuluag]

Great work!. 👍

[Kpopovs1]

This is ready for review @vaughanknight , @gfmatthews

[JenMadiedo]

🚢 -it

[vaughanknight]

Approved.

[Willmish]

See Merge conflicts after merging other PRs @Kpopovs1 - this one does not render in GH, and @vaughanknight looked at it locally and is unsure on documentation merge conflicts.

[Willmish]

Hi @Kpopovs1 - I can see that you are struggling with getting the DCO check to pass - its a new requirement in all GSF repositories. Please see #309 for more info.

As you are the sole author of these commits, you can rebase them and add signoff to each one of them. (this is not the preferred way, but it works)

However, and I can see that you are using the preferred way of adding a remediation commit. Since it looks like you have sign-offs from two seperate github emails, might be easier for you to reset the remediation commits and force push a clean remediation commit with the proper signoffs.

So more specifically - git reset both 5edd0e7 and 1dd1f12, and add in its a place a single remediation commit, which only has one sign-off at the bottom of it (only your MS email). You would need to force push those changes, but at least you don't have to modify the entire history of this branch by rebasing.

You can set the account name and email which are used for sign offs by default for a specific repository via:

git config --local user.name "Kristjana Popovski"
git config --local user.email "[email protected]"

[Kpopovs1]

Should be good to go! Let me know if you notice anything else @vaughanknight , @Willmish

[vaughanknight]

Second round of reviews, looks good.