Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datanode preflight dns check #20492

Merged
merged 12 commits into from
Oct 28, 2024
Merged

datanode preflight dns check #20492

merged 12 commits into from
Oct 28, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Sep 19, 2024

During preflight, check that the provided datanode hostname is actually bound to an IP in the system. This is important because we need to be able to reach the datanode by using this hostname. Incorrectly configured DNS may break the certificate provisioning and communication later during the setup.

Fixes #20503

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora marked this pull request as ready for review September 20, 2024 08:24
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change, otherwise looks good.
I am not too convinced that the check is super-meaningful since it might not be related to the dns used to resolve the name from Graylog or the other data nodes, but at least a simple user error can be caught.

…ht/DatanodeDnsPreflightCheck.java

Co-authored-by: Matthias Oesterheld <[email protected]>
@todvora
Copy link
Contributor Author

todvora commented Oct 23, 2024

@moesterheld You are right, it won't cover any network related problems, but it will catch a simple user configuration problem. Not overly helpful, but in the same time pretty simple implementation, so I hope we'll discover some problems even before they become big and hard to debug.

@todvora todvora merged commit 0d94bf1 into master Oct 28, 2024
6 checks passed
@todvora todvora deleted the datanode/dns-preflight-check branch October 28, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a DNS check during cert generation
2 participants