-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datanode preflight dns check #20492
datanode preflight dns check #20492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor change, otherwise looks good.
I am not too convinced that the check is super-meaningful since it might not be related to the dns used to resolve the name from Graylog or the other data nodes, but at least a simple user error can be caught.
data-node/src/main/java/org/graylog/datanode/bootstrap/preflight/DatanodeDnsPreflightCheck.java
Outdated
Show resolved
Hide resolved
…ht/DatanodeDnsPreflightCheck.java Co-authored-by: Matthias Oesterheld <[email protected]>
@moesterheld You are right, it won't cover any network related problems, but it will catch a simple user configuration problem. Not overly helpful, but in the same time pretty simple implementation, so I hope we'll discover some problems even before they become big and hard to debug. |
During preflight, check that the provided datanode hostname is actually bound to an IP in the system. This is important because we need to be able to reach the datanode by using this hostname. Incorrectly configured DNS may break the certificate provisioning and communication later during the setup.
Fixes #20503
Types of changes
Checklist: