Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes to the specification #49

Merged
merged 2 commits into from
May 7, 2024
Merged

Add attributes to the specification #49

merged 2 commits into from
May 7, 2024

Conversation

BenBrock
Copy link
Contributor

@BenBrock BenBrock commented Apr 1, 2024

Add the attributes key to the specification. Attributes provide optional information about a matrix which may be useful for certain optimizations, such as when reading a symmetric matrix from disk and creating a non-symmetric matrix in memory.

Copy link

github-actions bot commented Apr 1, 2024

Automated Review URLs

@BenBrock
Copy link
Contributor Author

BenBrock commented Apr 1, 2024

Possible attributes to add:

  • number_of_diagonal_elements
  • contains_cycles
  • Symmetry - do we want a symmetric attribute? symmetric, skew_symmetric, hermitian, anti-hermitian, structure_symmetric
  • invertible
  • positive_definite

@willow-ahrens
Copy link
Collaborator

Can we safely scope out numerical properties, such as invertible, rank, positive definite, etc., as they aren't really related to accelerating the reading and writing of the tensor?

@BenBrock BenBrock merged commit 51647ae into main May 7, 2024
1 check passed
@willow-ahrens
Copy link
Collaborator

I wonder if this could have been more user-defined. Since many more users may come along with special purpose acceleration attributes for their particular use cases, I'm not sure we want to be in the business of legislating what all of those optional attributes are, and we might have wanted to take the stance that those variables should live outside the spec, with perhaps a section of the JSON to describe user-defined attributes.

@BenBrock
Copy link
Contributor Author

That's a fair point, and we could always reverse this. I will add this to the agenda for our next meeting.

@BenBrock BenBrock deleted the attributes branch May 10, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants