Remove checkCipherData #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove checkCipherData, as it causes problems with AES192 and AES256. Block length is not always a multiple of key length.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove checkCipherData, as it causes problems with CA_ECDH_AES_CBC_CMAC_192 and CA_ECDH_AES_CBC_CMAC_256. Block size is not always a multiple of key size (ex AES). E.g. using CA_ECDH_AES_CBC_CMAC_192 the encoded key has a length of 192 bits (24 bytes), of which the AES block size (128 bits / 16 bytes) is not a multiple. An incorrect block size is also detected by the underlying classes. Removing this function call made it possible to run conformance tests with CA_ECDH_AES_CBC_CMAC_192 and CA_ECDH_AES_CBC_CMAC_256.
I attached a debugging screenshot of the updateEncryptedIV function showing the exception from the mentioned function.
Version 2.2.7 was used for confirming the bug.